|
Pierre-Yves Chibon |
1edad5 |
# -*- coding: utf-8 -*-
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
"""
|
|
Pierre-Yves Chibon |
1edad5 |
(c) 2015 - Copyright Red Hat Inc
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
Authors:
|
|
Pierre-Yves Chibon |
1edad5 |
Pierre-Yves Chibon <pingou@pingoured.fr></pingou@pingoured.fr>
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
"""
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
__requires__ = ['SQLAlchemy >= 0.8']
|
|
Pierre-Yves Chibon |
1edad5 |
import pkg_resources
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
import unittest
|
|
Pierre-Yves Chibon |
1edad5 |
import shutil
|
|
Pierre-Yves Chibon |
1edad5 |
import sys
|
|
Pierre-Yves Chibon |
1edad5 |
import os
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
import json
|
|
Pierre-Yves Chibon |
1edad5 |
from mock import patch
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
sys.path.insert(0, os.path.join(os.path.dirname(
|
|
Pierre-Yves Chibon |
1edad5 |
os.path.abspath(__file__)), '..'))
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
import pagure.lib
|
|
Pierre-Yves Chibon |
1edad5 |
import tests
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
class PagureFlaskInternaltests(tests.Modeltests):
|
|
Pierre-Yves Chibon |
1edad5 |
""" Tests for flask Internal controller of pagure """
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
def setUp(self):
|
|
Pierre-Yves Chibon |
1edad5 |
""" Set up the environnment, ran before every tests. """
|
|
Pierre-Yves Chibon |
1edad5 |
super(PagureFlaskInternaltests, self).setUp()
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.APP.config['TESTING'] = True
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.APP.config['IP_ALLOWED_INTERNAL'].append(None)
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.SESSION = self.session
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.internal.SESSION = self.session
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.APP.config['REQUESTS_FOLDER'] = None
|
|
Pierre-Yves Chibon |
1edad5 |
self.app = pagure.APP.test_client()
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
@patch('pagure.lib.notify.send_email')
|
|
Pierre-Yves Chibon |
1edad5 |
def test_pull_request_add_comment(self, send_email):
|
|
Pierre-Yves Chibon |
1edad5 |
""" Test the pull_request_add_comment function. """
|
|
Pierre-Yves Chibon |
1edad5 |
send_email.return_value = True
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
tests.create_projects(self.session)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
msg = pagure.lib.new_pull_request(
|
|
Pierre-Yves Chibon |
1edad5 |
session=self.session,
|
|
Pierre-Yves Chibon |
1edad5 |
repo_from=repo,
|
|
Pierre-Yves Chibon |
1edad5 |
branch_from='feature',
|
|
Pierre-Yves Chibon |
1edad5 |
repo_to=repo,
|
|
Pierre-Yves Chibon |
1edad5 |
branch_to='master',
|
|
Pierre-Yves Chibon |
1edad5 |
title='PR from the feature branch',
|
|
Pierre-Yves Chibon |
1edad5 |
user='pingou',
|
|
Pierre-Yves Chibon |
1edad5 |
requestfolder=None,
|
|
Pierre-Yves Chibon |
1edad5 |
)
|
|
Pierre-Yves Chibon |
1edad5 |
self.session.commit()
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(msg, 'Request created')
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
request = repo.requests[0]
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(len(request.comments), 0)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(len(request.discussion), 0)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
data = {
|
|
Pierre-Yves Chibon |
1edad5 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
1edad5 |
}
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Wrong http request
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.post('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 405)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Invalid request
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.put('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
data = {
|
|
Pierre-Yves Chibon |
1edad5 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
1edad5 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
1edad5 |
}
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Invalid objid
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.put('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 404)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
data = {
|
|
Pierre-Yves Chibon |
1edad5 |
'objid': request.uid,
|
|
Pierre-Yves Chibon |
1edad5 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
1edad5 |
}
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Valid objid, in-complete data for a comment
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.put('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
data = {
|
|
Pierre-Yves Chibon |
1edad5 |
'objid': request.uid,
|
|
Pierre-Yves Chibon |
1edad5 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
1edad5 |
'comment': 'Looks good to me!',
|
|
Pierre-Yves Chibon |
1edad5 |
}
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Add comment
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.put('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 200)
|
|
Pierre-Yves Chibon |
1edad5 |
js_data = json.loads(output.data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertDictEqual(js_data, {'message': 'Comment added'})
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
1edad5 |
request = repo.requests[0]
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(len(request.comments), 1)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(len(request.discussion), 1)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
# Check the @localonly
|
|
Pierre-Yves Chibon |
1edad5 |
pagure.APP.config['IP_ALLOWED_INTERNAL'].remove(None)
|
|
Pierre-Yves Chibon |
1edad5 |
output = self.app.put('/pv/pull-request/comment/', data=data)
|
|
Pierre-Yves Chibon |
1edad5 |
self.assertEqual(output.status_code, 403)
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
21ea63 |
@patch('pagure.lib.notify.send_email')
|
|
Pierre-Yves Chibon |
21ea63 |
def test_ticket_add_comment(self, send_email):
|
|
Pierre-Yves Chibon |
21ea63 |
""" Test the ticket_add_comment function. """
|
|
Pierre-Yves Chibon |
21ea63 |
send_email.return_value = True
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
tests.create_projects(self.session)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Create issues to play with
|
|
Pierre-Yves Chibon |
21ea63 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
21ea63 |
msg = pagure.lib.new_issue(
|
|
Pierre-Yves Chibon |
21ea63 |
session=self.session,
|
|
Pierre-Yves Chibon |
21ea63 |
repo=repo,
|
|
Pierre-Yves Chibon |
21ea63 |
title='Test issue',
|
|
Pierre-Yves Chibon |
21ea63 |
content='We should work on this',
|
|
Pierre-Yves Chibon |
21ea63 |
user='pingou',
|
|
Pierre-Yves Chibon |
21ea63 |
ticketfolder=None
|
|
Pierre-Yves Chibon |
21ea63 |
)
|
|
Pierre-Yves Chibon |
21ea63 |
self.session.commit()
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(msg.title, 'Test issue')
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
issue = repo.issues[0]
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(len(issue.comments), 0)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
data = {
|
|
Pierre-Yves Chibon |
21ea63 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
21ea63 |
}
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Wrong http request
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.post('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 405)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Invalid request
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
data = {
|
|
Pierre-Yves Chibon |
21ea63 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
21ea63 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
21ea63 |
}
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Invalid objid
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 404)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
data = {
|
|
Pierre-Yves Chibon |
21ea63 |
'objid': issue.uid,
|
|
Pierre-Yves Chibon |
21ea63 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
21ea63 |
}
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Valid objid, in-complete data for a comment
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
data = {
|
|
Pierre-Yves Chibon |
0bf136 |
'objid': issue.uid,
|
|
Pierre-Yves Chibon |
0bf136 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
0bf136 |
'comment': 'Looks good to me!',
|
|
Pierre-Yves Chibon |
0bf136 |
}
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Add comment
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 200)
|
|
Pierre-Yves Chibon |
0bf136 |
js_data = json.loads(output.data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertDictEqual(js_data, {'message': 'Comment added'})
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
0bf136 |
issue = repo.issues[0]
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(len(issue.comments), 1)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Check the @localonly
|
|
Pierre-Yves Chibon |
0bf136 |
pagure.APP.config['IP_ALLOWED_INTERNAL'].remove(None)
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 403)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
@patch('pagure.lib.notify.send_email')
|
|
Pierre-Yves Chibon |
0bf136 |
def test_private_ticket_add_comment(self, send_email):
|
|
Pierre-Yves Chibon |
0bf136 |
""" Test the ticket_add_comment function on a private ticket. """
|
|
Pierre-Yves Chibon |
0bf136 |
send_email.return_value = True
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
tests.create_projects(self.session)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Create issues to play with
|
|
Pierre-Yves Chibon |
0bf136 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
0bf136 |
msg = pagure.lib.new_issue(
|
|
Pierre-Yves Chibon |
0bf136 |
session=self.session,
|
|
Pierre-Yves Chibon |
0bf136 |
repo=repo,
|
|
Pierre-Yves Chibon |
0bf136 |
title='Test issue',
|
|
Pierre-Yves Chibon |
0bf136 |
content='We should work on this, really',
|
|
Pierre-Yves Chibon |
0bf136 |
user='pingou',
|
|
Pierre-Yves Chibon |
0bf136 |
private=True,
|
|
Pierre-Yves Chibon |
0bf136 |
ticketfolder=None
|
|
Pierre-Yves Chibon |
0bf136 |
)
|
|
Pierre-Yves Chibon |
0bf136 |
self.session.commit()
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(msg.title, 'Test issue')
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
issue = repo.issues[0]
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(len(issue.comments), 0)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
data = {
|
|
Pierre-Yves Chibon |
0bf136 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
0bf136 |
}
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Wrong http request
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.post('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 405)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Invalid request
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
data = {
|
|
Pierre-Yves Chibon |
0bf136 |
'objid': 'foo',
|
|
Pierre-Yves Chibon |
0bf136 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
0bf136 |
}
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Invalid objid
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 404)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
data = {
|
|
Pierre-Yves Chibon |
0bf136 |
'objid': issue.uid,
|
|
Pierre-Yves Chibon |
0bf136 |
'useremail': 'foo@bar.com',
|
|
Pierre-Yves Chibon |
0bf136 |
}
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Valid objid, un-allowed user for this (private) ticket
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
0bf136 |
self.assertEqual(output.status_code, 403)
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
data = {
|
|
Pierre-Yves Chibon |
0bf136 |
'objid': issue.uid,
|
|
Pierre-Yves Chibon |
0bf136 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
0bf136 |
}
|
|
Pierre-Yves Chibon |
0bf136 |
|
|
Pierre-Yves Chibon |
0bf136 |
# Valid objid, un-allowed user for this (private) ticket
|
|
Pierre-Yves Chibon |
0bf136 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 400)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
data = {
|
|
Pierre-Yves Chibon |
21ea63 |
'objid': issue.uid,
|
|
Pierre-Yves Chibon |
21ea63 |
'useremail': 'foo@pingou.com',
|
|
Pierre-Yves Chibon |
21ea63 |
'comment': 'Looks good to me!',
|
|
Pierre-Yves Chibon |
21ea63 |
}
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Add comment
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 200)
|
|
Pierre-Yves Chibon |
21ea63 |
js_data = json.loads(output.data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertDictEqual(js_data, {'message': 'Comment added'})
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
repo = pagure.lib.get_project(self.session, 'test')
|
|
Pierre-Yves Chibon |
21ea63 |
issue = repo.issues[0]
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(len(issue.comments), 1)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
21ea63 |
# Check the @localonly
|
|
Pierre-Yves Chibon |
21ea63 |
pagure.APP.config['IP_ALLOWED_INTERNAL'].remove(None)
|
|
Pierre-Yves Chibon |
21ea63 |
output = self.app.put('/pv/ticket/comment/', data=data)
|
|
Pierre-Yves Chibon |
21ea63 |
self.assertEqual(output.status_code, 403)
|
|
Pierre-Yves Chibon |
21ea63 |
|
|
Pierre-Yves Chibon |
1edad5 |
|
|
Pierre-Yves Chibon |
1edad5 |
if __name__ == '__main__':
|
|
Pierre-Yves Chibon |
1edad5 |
SUITE = unittest.TestLoader().loadTestsFromTestCase(
|
|
Pierre-Yves Chibon |
1edad5 |
PagureFlaskInternaltests)
|
|
Pierre-Yves Chibon |
1edad5 |
unittest.TextTestRunner(verbosity=2).run(SUITE)
|