From 1eb4ca3ba47f56f75d85176430f0b6c3c62f22eb Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jan 05 2015 09:39:18 +0000
Subject: Make the `add_tag_issue` endpoint only accept POST queries and not return json


---

diff --git a/progit/ui/issues.py b/progit/ui/issues.py
index e0d23f6..66d5c52 100644
--- a/progit/ui/issues.py
+++ b/progit/ui/issues.py
@@ -69,14 +69,11 @@ def add_comment_issue(repo, issueid, username=None):
         'view_issue', username=username, repo=repo.name, issueid=issueid))
 
 
-@APP.route('/<repo>/issue/<int:issueid>/tag', methods=('GET', 'POST'))
+@APP.route('/<repo>/issue/<int:issueid>/tag', methods=['POST'])
 @APP.route('/fork/<username>/<repo>/issue/<int:issueid>/tag',
-           methods=('GET', 'POST'))
-@APP.route('/<repo>/issue/<int:issueid>/tag/<chrome>', methods=('GET', 'POST'))
-@APP.route('/fork/<username>/<repo>/issue/<int:issueid>/tag/<chrome>',
-           methods=('GET', 'POST'))
+           methods=['POST'])
 @cla_required
-def add_tag_issue(repo, issueid, username=None, chrome=True):
+def add_tag_issue(repo, issueid, username=None):
     ''' Add a tag to an issue. '''
     repo = progit.lib.get_project(SESSION, repo, user=username)
 
@@ -107,28 +104,14 @@ def add_tag_issue(repo, issueid, username=None, chrome=True):
                     ticketfolder=APP.config['TICKETS_FOLDER'],
                 )
                 SESSION.commit()
-                msg = 'Added tag: %s' % tag
-                flask.flash(msg)
+                flask.flash(message)
             except SQLAlchemyError, err:  # pragma: no cover
                 SESSION.rollback()
                 LOG.error(err)
                 flask.flash('Could not add tag: %s' % tag, 'error')
 
-    if not chrome:
-        if cat is not None:
-            output = {'output': 'notok', 'message': msg}
-            httpcode = 500
-        else:
-            output = {'output': 'ok', 'message': msg}
-            httpcode = 200
-
-        jsonout = flask.jsonify(output)
-        jsonout.status_code = httpcode
-        return jsonout
-
-    else:
-        return flask.redirect(flask.url_for(
-            'view_issue', username=username, repo=repo.name, issueid=issueid))
+    return flask.redirect(flask.url_for(
+        'view_issue', username=username, repo=repo.name, issueid=issueid))
 
 
 @APP.route('/<repo>/tag/<tag>/edit', methods=('GET', 'POST'))