From 4595eddf7f4e3c90c3b53a062f30eb1f102d4138 Mon Sep 17 00:00:00 2001
From: farhaanbukhsh <farhaan.bukhsh@gmail.com>
Date: Apr 14 2017 10:32:36 +0000
Subject: Fix parameter


---

diff --git a/pagure/ui/repo.py b/pagure/ui/repo.py
index d3175b6..e47d172 100644
--- a/pagure/ui/repo.py
+++ b/pagure/ui/repo.py
@@ -893,12 +893,6 @@ def view_forks(repo, username=None, namespace=None):
     """
     repo = flask.g.repo
 
-    if not repo:
-        flask.abort(404, 'Project not found')
-
-    if repo.private and not is_repo_admin(repo):
-        flask.abort(401, 'Forbidden')
-
     return flask.render_template(
         'forks.html',
         select='forks',
@@ -931,7 +925,6 @@ def view_tags(repo, username=None, namespace=None):
 
 
 @APP.route('/<repo>/upload/', methods=('GET', 'POST'))
-@APP.route('/<repo>/upload', methods=('GET', 'POST'))
 @APP.route('/<namespace>/<repo>/upload/', methods=('GET', 'POST'))
 @APP.route('/<namespace>/<repo>/upload', methods=('GET', 'POST'))
 @APP.route('/fork/<username>/<repo>/upload/', methods=('GET', 'POST'))
@@ -1197,9 +1190,6 @@ def update_priorities(repo, username=None, namespace=None):
 
     repo = flask.g.repo
 
-    if repo.private and not is_repo_admin(repo):
-        flask.abort(401, 'Forbidden')
-
     if not repo.settings.get('issue_tracker', True):
         flask.abort(404, 'No issue tracker found for this project')
 
@@ -1715,10 +1705,9 @@ def add_user(repo, username=None, namespace=None):
     repo = flask.g.repo
 
     if not flask.g.repo_admin:
-        flask.abort(404, 'Project not found')
-
-    if repo.private and not is_repo_admin(repo):
-        flask.abort(401, 'Forbidden')
+        flask.abort(
+            403,
+            'You are not allowed to add users to this project')
 
     user_to_update = flask.request.args.get('user', '').strip()
     user_to_update_obj = None
@@ -2239,9 +2228,6 @@ def view_docs(repo, username=None, filename=None, namespace=None):
     """
     repo = flask.g.repo
 
-    if repo_obj.private and not is_repo_admin(repo_obj):
-        flask.abort(401, 'Forbidden')
-
     if not APP.config.get('DOC_APP_URL'):
         flask.abort(404, 'This pagure instance has no doc server')
 
@@ -2268,9 +2254,6 @@ def view_project_activity(repo, namespace=None):
 
     repo = flask.g.repo
 
-    if repo_obj.private and not is_repo_admin(repo_obj):
-        flask.abort(401, 'Forbidden')
-
     return flask.render_template(
         'activity.html',
         repo=repo,