From 671c7992070a59015deab8cb8917886e050cb661 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 05 2019 15:53:49 +0000 Subject: Skip running flake8 on old flake8 version It returns too many false-positive Signed-off-by: Pierre-Yves Chibon --- diff --git a/tests/test_style.py b/tests/test_style.py index 31e5fa3..6af9509 100644 --- a/tests/test_style.py +++ b/tests/test_style.py @@ -38,6 +38,21 @@ class TestStyle(unittest.TestCase): sys.executable, '-m', 'flake8', '--ignore=E712,W503,E203', REPO_PATH ] + + # check if we have an old flake8 or not + import flake8 + flake8_v = flake8.__version__.split('.') + for idx, val in enumerate(flake8_v): + try: + val = int(val) + except ValueError: + pass + flake8_v[idx] = val + old_flake = tuple(flake8_v) < (3, 0) + + if old_flake: + raise unittest.SkipTest("Flake8 version too old to be useful") + proc = subprocess.Popen( flake8_command, stdout=subprocess.PIPE,