From 69437809a79d28829a5d7798a5502875e94bb4a6 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Feb 15 2017 09:05:26 +0000
Subject: Email the user about the output of the upload to the DB


With this change we will inform the user by email about the outcome of
the load. If an error has occurred, it will be included in the email, so
that an admin can then look further into it.

---

diff --git a/pagure-loadjson/pagure_loadjson_server.py b/pagure-loadjson/pagure_loadjson_server.py
index 8848b08..8ab6f91 100644
--- a/pagure-loadjson/pagure_loadjson_server.py
+++ b/pagure-loadjson/pagure_loadjson_server.py
@@ -21,11 +21,13 @@ pagure can be really time-consuming).
 import json
 import logging
 import os
+import traceback
 
 import requests
 import trollius
 import trollius_redis
 
+from sqlalchemy.exc import SQLAlchemyError
 
 _log = logging.getLogger(__name__)
 
@@ -36,9 +38,29 @@ if 'PAGURE_CONFIG' not in os.environ \
 
 
 import pagure
+import pagure.exceptions
 import pagure.lib
+import pagure.lib.notify
 
 
+def format_callstack():
+    """ Format the callstack to find out the stack trace. """
+    ind = 0
+    for ind, frame in enumerate(f[0] for f in inspect.stack()):
+        if '__name__' not in frame.f_globals:
+            continue
+        modname = frame.f_globals['__name__'].split('.')[0]
+        if modname != "logging":
+            break
+
+    def _format_frame(frame):
+        """ Format the frame. """
+        return '  File "%s", line %i in %s\n    %s' % (frame)
+
+    stack = traceback.extract_stack()
+    stack = stack[:-ind]
+    return "\n".join([_format_frame(frame) for frame in stack])
+
 def get_files_to_load(title, new_commits_list, abspath):
 
     _log.info('%s: Retrieve the list of files changed' % title)
@@ -89,7 +111,9 @@ def handle_messages():
             "b7b4059c44d692d7df3227ce58ce01191e5407bd",
             "f8d0899bb6654590ffdef66b539fd3b8cf873b35",
             "9b6fdc48d3edab82d3de28953271ea52b0a96117"
-          ]
+          ],
+          "data_type": "ticket",
+          "agent": "pingou",
         }
 
     '''
@@ -121,6 +145,7 @@ def handle_messages():
             if data['project']['parent'] else None
         namespace = data['project']['namespace']
         data_type = data['data_type']
+        agent = data['agent']
 
         if data_type not in ['ticket', 'pull-request']:
             _log.info('Invalid data_type retrieved: %s', data_type)
@@ -147,9 +172,11 @@ def handle_messages():
         file_list = set(get_files_to_load(project.fullname, commits, abspath))
         n = len(file_list)
         _log.info('%s files to process' % n)
+        mail_body = []
 
         for idx, filename in enumerate(file_list):
-            _log.info('Loading: %s -- %s/%s', filename, idx, n)
+            _log.info('Loading: %s -- %s/%s', filename, idx+1, n)
+            tmp = 'Loading: %s -- %s/%s' % (filename, idx+1, n)
             json_data = None
             data = ''.join(
                 pagure.lib.git.read_git_lines(
@@ -170,14 +197,32 @@ def handle_messages():
                             issue_uid=filename,
                             json_data=json_data
                         )
+                        tmp += ' ... ... Done'
                 except Exception as err:
                     _log.info('data: %s', json_data)
                     session.rollback()
                     _log.exception(err)
+                    tmp += ' ... ... FAILED\n'
+                    tmp += format_callstack()
                     break
+                finally:
+                    mail_body.append(tmp)
 
         try:
             session.commit()
+            _log.info(
+                'Emailing results for %s to %s', project.fullname, agent)
+            try:
+                if not agent:
+                    raise pagure.exceptions.PagureException(
+                        'No agent found: %s' % agent)
+                user_obj = pagure.lib.get_user(session, agent)
+                pagure.lib.notify.send_email(
+                    '\n'.join(mail_body),
+                    'Issue import report',
+                    user_obj.default_email)
+            except pagure.exceptions.PagureException as err:
+                _log.exception('Could not find user %s' % agent)
         except SQLAlchemyError as err:  # pragma: no cover
             session.rollback()
         finally:
diff --git a/pagure/hooks/files/pagure_hook_tickets.py b/pagure/hooks/files/pagure_hook_tickets.py
index f684ce3..84b1150 100644
--- a/pagure/hooks/files/pagure_hook_tickets.py
+++ b/pagure/hooks/files/pagure_hook_tickets.py
@@ -63,15 +63,21 @@ def run_as_post_receive_hook():
             oldrev, newrev, abspath, refname)
 
         if REDIS:
-            print('Sending to redis to log activity')
+            print('Sending to redis to load the data')
             REDIS.publish('pagure.loadjson',
                 json.dumps({
                     'project': project.to_json(public=True),
                     'abspath': abspath,
                     'commits': commits,
                     'data_type': 'ticket',
+                    'agent': os.environ.get('GL_USER'),
                 }
             ))
+            print(
+                'A report will be emailed to you once the load is finished')
+        else:
+            print('Hook not configured to connect to pagure-loadjson')
+            print('/!\ Your data will not be loaded into the database!')
 
 
 def main(args):