From a7717f0a1fbbfcd147c2e7bbc2d14bb549521daf Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Nov 14 2018 14:30:07 +0000
Subject: Let any contributor to a project update the PR meta-data


Before this we were considering that only people with commit access could
work on PR, but that's not quite true, we should let people with ticket
access be able to triage PR as well and thus edit their meta-data.

Fixes https://pagure.io/pagure/issue/3967

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure/templates/repo_pull_request.html b/pagure/templates/repo_pull_request.html
index 2f1bef1..da8d9a2 100644
--- a/pagure/templates/repo_pull_request.html
+++ b/pagure/templates/repo_pull_request.html
@@ -477,7 +477,7 @@
         <h5 class="d-flex align-items-center font-weight-bold border-bottom">
           <div class="py-2 text-uppercase font-size-09">Metadata</div>
           {% if g.authenticated and mergeform
-          and (g.repo_committer
+          and (g.repo_user
               or g.fas_user.username == pull_request.user.user) %}
           <div class="ml-auto">
           <a class="btn btn-outline-primary border-0 btn-sm issue-metadata-display editmetadatatoggle" href="javascript:void(0)"><i class="fa fa-fw fa-pencil"></i></a>
@@ -485,7 +485,7 @@
           </div>
         {% endif %}
         </h5>
-        {% if g.authenticated and mergeform and g.repo_committer %}
+        {% if g.authenticated and mergeform and g.repo_user %}
           <form method="POST" action="{{ url_for('ui_ns.update_pull_requests',
               repo=repo.name,
               username=username,
@@ -545,7 +545,7 @@
         </fieldset>
 
         {% if g.authenticated and mergeform
-                and (g.repo_committer
+                and (g.repo_user
                     or g.fas_user.username == pull_request.user.user) %}
               <input type="submit" class="btn btn-primary issue-metadata-form hidden" value="Update">
             </form>
diff --git a/pagure/ui/fork.py b/pagure/ui/fork.py
index c0c743e..9cdd84b 100644
--- a/pagure/ui/fork.py
+++ b/pagure/ui/fork.py
@@ -1377,7 +1377,7 @@ def update_pull_requests(repo, requestid, username=None, namespace=None):
         flask.abort(404, "Pull-request not found")
 
     if (
-        not flask.g.repo_committer
+        not flask.g.repo_user
         and flask.g.fas_user.username != request.user.username
     ):
         flask.abort(403, "You are not allowed to update this pull-request")
@@ -1401,7 +1401,7 @@ def update_pull_requests(repo, requestid, username=None, namespace=None):
             )
             messages = messages.union(set(msgs))
 
-            if flask.g.repo_committer:
+            if flask.g.repo_user:
                 # Assign or update assignee of the ticket
                 msg = pagure.lib.query.add_pull_request_assignee(
                     flask.g.session,