From aa715b12ecf38bf99bfbb348d0bec8876b74f708 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Feb 24 2017 08:48:07 +0000 Subject: Do not notify the SSE server on comment added to a ticket via git We should notify the SSE server even on update of the ticket via git push to the ticket repo (the only case where notify=False basically), but this causes problem with some of our markdown extension so until we figure this out, we won't do live-refresh. Eventually, we could do the markdown conversion in its own service and store the results in the DB where we would then retrieve it. --- diff --git a/pagure/lib/__init__.py b/pagure/lib/__init__.py index c847011..6615658 100644 --- a/pagure/lib/__init__.py +++ b/pagure/lib/__init__.py @@ -337,7 +337,11 @@ def add_issue_comment(session, issue, comment, user, ticketfolder, redis=REDIS, ) - if REDIS: + # TODO: we should notify the SSE server even on update of the ticket + # via git push to the ticket repo (the only case where notify=False + # basically), but this causes problem with some of our markdown extension + # so until we figure this out, we won't do live-refresh + if REDIS and notify: if issue.private: REDIS.publish('pagure.%s' % issue.uid, json.dumps({ 'issue': 'private',