From c35959e946f496a2db67ecc33eea895a6bc96731 Mon Sep 17 00:00:00 2001
From: Pierre-Yves Chibon <pingou@pingoured.fr>
Date: Jan 19 2019 09:19:51 +0000
Subject: Ensure there are admin groups before adding them to the list of groups


If in the config ADMIN_GROUP is defined as None, it was added to the
list of groups to query the openid server for.
Which resulted in a set containing a None element, which broke loging
in.

Signed-off-by: Pierre-Yves Chibon <pingou@pingoured.fr>

---

diff --git a/pagure/flask_app.py b/pagure/flask_app.py
index b52f366..dafe585 100644
--- a/pagure/flask_app.py
+++ b/pagure/flask_app.py
@@ -398,10 +398,13 @@ def auth_login():  # pragma: no cover
         return flask.redirect(return_point)
 
     admins = pagure_config["ADMIN_GROUP"]
-    if isinstance(admins, list):
-        admins = set(admins)
-    else:  # pragma: no cover
-        admins = set([admins])
+    if admins:
+        if isinstance(admins, list):
+            admins = set(admins)
+        else:  # pragma: no cover
+            admins = set([admins])
+    else:
+        admins = set()
 
     if auth in ["fas", "openid"]:
         from pagure.ui.fas_login import FAS