From efb2ec12f92981e34f2ebc80be195457a0708034 Mon Sep 17 00:00:00 2001 From: Pierre-Yves Chibon Date: Dec 24 2015 09:22:02 +0000 Subject: Adjust unit-tests for the ui/repo.py controller --- diff --git a/tests/test_progit_flask_ui_repo.py b/tests/test_progit_flask_ui_repo.py index 58dda0c..ed24ad8 100644 --- a/tests/test_progit_flask_ui_repo.py +++ b/tests/test_progit_flask_ui_repo.py @@ -84,8 +84,8 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/') self.assertEqual(output.status_code, 200) self.assertIn( - '
  • Action canceled, try it again
  • ', - output.data) + '\n Action canceled, try it ' + 'again',output.data) ast.return_value = False @@ -93,9 +93,7 @@ class PagureFlaskRepotests(tests.Modeltests): with tests.user_set(pagure.APP, user): output = self.app.get('/test/adduser') self.assertEqual(output.status_code, 200) - self.assertTrue('

    Add user

    ' in output.data) - self.assertTrue( - '' in output.data) + self.assertIn('

    Add user

    ', output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -107,26 +105,25 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post('/test/adduser', data=data) self.assertEqual(output.status_code, 200) self.assertTrue('

    Add user

    ' in output.data) - self.assertTrue( - '' in output.data) data['csrf_token'] = csrf_token output = self.app.post('/test/adduser', data=data) self.assertEqual(output.status_code, 200) - self.assertTrue('

    Add user

    ' in output.data) - self.assertTrue( - '
  • No user "ralph" found
  • ' - in output.data) + self.assertIn('

    Add user

    ', output.data) + self.assertIn( + '\n No user "ralph" ' + 'found', output.data) data['user'] = 'foo' tests.create_projects_git(tests.HERE) output = self.app.post( '/test/adduser', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
  • User added
  • ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '\n User added', output.data) @patch('pagure.ui.repo.admin_session_timedout') def test_add_group_project(self, ast): @@ -157,8 +154,8 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/') self.assertEqual(output.status_code, 200) self.assertIn( - '
  • Action canceled, try it again
  • ', - output.data) + '\n Action canceled, try it ' + 'again', output.data) ast.return_value = False @@ -177,8 +174,6 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/test/addgroup') self.assertEqual(output.status_code, 200) self.assertTrue('

    Add group

    ' in output.data) - self.assertTrue( - '' in output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -190,26 +185,25 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post('/test/addgroup', data=data) self.assertEqual(output.status_code, 200) self.assertTrue('

    Add group

    ' in output.data) - self.assertTrue( - '' in output.data) data['csrf_token'] = csrf_token output = self.app.post('/test/addgroup', data=data) self.assertEqual(output.status_code, 200) self.assertTrue('

    Add group

    ' in output.data) - self.assertTrue( - '
  • No group ralph found.
  • ' - in output.data) + self.assertIn( + '\n No group ralph found.', + output.data) data['group'] = 'foo' tests.create_projects_git(tests.HERE) output = self.app.post( '/test/addgroup', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
  • Group added
  • ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '\n Group added', output.data) @patch('pagure.ui.repo.admin_session_timedout') def test_remove_user(self, ast): @@ -247,11 +241,12 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/dropuser/2', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
  • User does not have commit or cannot ' - 'loose it right
  • ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '\n User does not have commit or cannot ' + 'loose it right', output.data) # Add an user to a project repo = pagure.lib.get_project(self.session, 'test') @@ -267,21 +262,21 @@ class PagureFlaskRepotests(tests.Modeltests): with tests.user_set(pagure.APP, user): output = self.app.post('/test/dropuser/2', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) - self.assertFalse( - '
  • User removed
  • ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertNotIn( + '\n User removed', output.data) data = {'csrf_token': csrf_token} output = self.app.post( '/test/dropuser/2', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
  • User removed
  • ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '\n User removed', output.data) @patch('pagure.ui.repo.admin_session_timedout') def test_update_project(self, ast): @@ -311,10 +306,9 @@ class PagureFlaskRepotests(tests.Modeltests): tests.create_projects_git(tests.HERE) output = self.app.post('/test/update', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -326,13 +320,14 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/update', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) self.assertIn( - '', output.data) - self.assertTrue( - '
  • Project updated
  • ' - in output.data) + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '', output.data) + self.assertIn( + '\n Project updated', + output.data) # Edit the avatar_email data = { @@ -343,14 +338,15 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/update', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) self.assertIn( - '', + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '', + output.data) + self.assertIn( + '\n Project updated', output.data) - self.assertTrue( - '
  • Project updated
  • ' - in output.data) # Reset the avatar_email data = { @@ -361,14 +357,14 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/update', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) self.assertIn( - '', + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( + '', output.data) + self.assertIn( + '\n Project updated', output.data) - self.assertTrue( - '
  • Project updated
  • ' - in output.data) @patch('pagure.ui.repo.admin_session_timedout') def test_view_settings(self, ast): @@ -398,17 +394,17 @@ class PagureFlaskRepotests(tests.Modeltests): ast.return_value = False output = self.app.get('/test/settings') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + # Both checkbox checked before - self.assertTrue( + self.assertIn( '' in output.data) - self.assertTrue( + 'name="pull_requests" checked=""/>', output.data) + self.assertIn( '' in output.data) + 'name="issue_tracker" checked=""/>', output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -417,50 +413,48 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/settings', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) # Both checkbox are still checked output = self.app.get('/test/settings', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) - self.assertTrue( + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( '' in output.data) - self.assertTrue( + 'name="pull_requests" checked=""/>', output.data) + self.assertIn( '' in output.data) + 'name="issue_tracker" checked=""/>', output.data) data = {'csrf_token': csrf_token} output = self.app.post( '/test/settings', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) - self.assertTrue( - 'Overview - test - Pagure' in output.data) - self.assertTrue( - '
  • Edited successfully settings of ' - 'repo: test
  • ' in output.data) + self.assertIn( + 'Overview - test - Pagure', output.data) + self.assertIn( + '
    \n

    test project #1

    ', + output.data) + self.assertIn( + '\n Edited successfully ' + 'settings of repo: test', output.data) # Both checkbox are now un-checked output = self.app.get('/test/settings', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) - self.assertTrue( + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( '' in output.data) - self.assertTrue( + 'name="pull_requests" />', output.data) + self.assertIn( '' in output.data) + 'name="issue_tracker" />', output.data) data = { 'csrf_token': csrf_token, @@ -470,27 +464,27 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.post( '/test/settings', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) - self.assertTrue( - 'Overview - test - Pagure' in output.data) - self.assertTrue( - '
  • Edited successfully settings of ' - 'repo: test
  • ' in output.data) + self.assertIn( + 'Overview - test - Pagure', output.data) + self.assertIn( + '
    \n

    test project #1

    ', + output.data) + self.assertIn( + '\n Edited successfully ' + 'settings of repo: test', output.data) # Both checkbox are again checked output = self.app.get('/test/settings', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Settings

    ' in output.data) - self.assertTrue( - '
      \n
    ' in output.data) - self.assertTrue( + self.assertIn( + 'Settings - test - Pagure', output.data) + self.assertIn('

    Settings for test

    ', output.data) + self.assertIn( '' in output.data) - self.assertTrue( + 'name="pull_requests" checked=""/>', output.data) + self.assertIn( '' in output.data) + 'name="issue_tracker" checked=""/>', output.data) def test_view_forks(self): """ Test the view_forks endpoint. """ @@ -533,8 +527,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertFalse('Forked from' in output.data) self.assertTrue('

    test project #1

    ' in output.data) - self.assertEqual( - output.data.count(''), 3) # Turn that repo into a fork repo = pagure.lib.get_project(self.session, 'test') @@ -557,8 +549,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertTrue('

    test project #1

    ' in output.data) self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 3) # Add a fork of a fork item = pagure.lib.model.Project( @@ -584,8 +574,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertTrue('

    test project #3

    ' in output.data) self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 3) def test_view_repo_empty(self): """ Test the view_repo endpoint on a repo w/o master branch. """ @@ -658,8 +646,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertFalse('Forked from' in output.data) self.assertTrue('

    test project #1

    ' in output.data) - self.assertEqual( - output.data.count(''), 3) # Turn that repo into a fork repo = pagure.lib.get_project(self.session, 'test') @@ -682,8 +668,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertTrue('

    test project #1

    ' in output.data) self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 3) # Add a fork of a fork item = pagure.lib.model.Project( @@ -709,8 +693,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertFalse('

    This repo is brand new!

    ' in output.data) self.assertTrue('

    test project #3

    ' in output.data) self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 10) def test_view_commits(self): """ Test the view_commits endpoint. """ @@ -728,8 +710,8 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/test/commits') self.assertEqual(output.status_code, 200) - self.assertTrue('

    This repo is brand new!

    ' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) + self.assertIn('

    This repo is brand new!

    ', output.data) + self.assertIn('

    test project #1

    ', output.data) # Add some content to the git repo tests.add_content_git_repo(os.path.join(tests.HERE, 'test.git')) @@ -737,19 +719,16 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/test/commits') self.assertEqual(output.status_code, 200) - self.assertFalse('

    This repo is brand new!

    ' in output.data) - self.assertFalse('Forked from' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) - self.assertEqual( - output.data.count(''), 3) + self.assertNotIn('

    This repo is brand new!

    ', output.data) + self.assertNotIn('Forked from', output.data) + self.assertIn('

    test project #1

    ', output.data) + self.assertIn('Logs - test - Pagure', output.data) output = self.app.get('/test/commits/master') self.assertEqual(output.status_code, 200) - self.assertFalse('

    This repo is brand new!

    ' in output.data) - self.assertFalse('Forked from' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) - self.assertEqual( - output.data.count(''), 3) + self.assertNotIn('

    This repo is brand new!

    ', output.data) + self.assertNotIn('Forked from', output.data) + self.assertIn('

    test project #1

    ', output.data) # Turn that repo into a fork repo = pagure.lib.get_project(self.session, 'test') @@ -769,11 +748,9 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/fork/pingou/test/commits?page=abc') self.assertEqual(output.status_code, 200) - self.assertFalse('

    This repo is brand new!

    ' in output.data) - self.assertTrue('

    test project #1

    ' in output.data) - self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 3) + self.assertNotIn('

    This repo is brand new!

    ', output.data) + self.assertIn('

    test project #1

    ', output.data) + self.assertIn('Forked from', output.data) # Add a fork of a fork item = pagure.lib.model.Project( @@ -799,11 +776,9 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/fork/pingou/test3/commits') self.assertEqual(output.status_code, 200) - self.assertFalse('

    This repo is brand new!

    ' in output.data) - self.assertTrue('

    test project #3

    ' in output.data) - self.assertTrue('Forked from' in output.data) - self.assertEqual( - output.data.count(''), 13) + self.assertNotIn('

    This repo is brand new!

    ', output.data) + self.assertIn('

    test project #3

    ', output.data) + self.assertIn('Forked from', output.data) def test_view_file(self): """ Test the view_file endpoint. """ @@ -836,7 +811,7 @@ class PagureFlaskRepotests(tests.Modeltests): # View in a branch output = self.app.get('/test/blob/master/f/sources') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) + self.assertTrue('' in output.data) self.assertTrue( '' in output.data) @@ -846,9 +821,11 @@ class PagureFlaskRepotests(tests.Modeltests): # View what's supposed to be an image output = self.app.get('/test/blob/master/f/test.jpg') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue( - 'Binary files cannot be rendered.
    ' in output.data) + self.assertIn( + 'Binary files cannot be rendered.
    ', output.data) + self.assertIn( + 'view the raw version', + output.data) # View by commit id repo = pygit2.Repository(os.path.join(tests.HERE, 'test.git')) @@ -856,22 +833,21 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/test/blob/%s/f/test.jpg' % commit.oid.hex) self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue( - 'Binary files cannot be rendered.
    ' in output.data) + self.assertIn( + 'Binary files cannot be rendered.
    ', output.data) + self.assertIn('/f/test.jpg">view the raw version', output.data) # View by image name -- somehow we support this output = self.app.get('/test/blob/sources/f/test.jpg') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue( - 'Binary files cannot be rendered.
    ' - in output.data) + self.assertIn( + 'Binary files cannot be rendered.
    ', output.data) + self.assertIn('/f/test.jpg">view the raw version', output.data) # View binary file output = self.app.get('/test/blob/sources/f/test_binary') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) + self.assertIn('/f/test_binary">view the raw version', output.data) # In newer pygit2 patch.is_binary behaves differently #self.assertTrue( #'Binary files cannot be rendered.
    ' @@ -880,10 +856,12 @@ class PagureFlaskRepotests(tests.Modeltests): # View folder output = self.app.get('/test/blob/master/f/folder1') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue('

    Tree

    ' in output.data) - self.assertTrue( - '
    ' in output.data) + self.assertIn( + '', + output.data) + self.assertIn('Tree - test - Pagure', output.data) + self.assertIn( + '', output.data) # View by image name -- with a non-existant file output = self.app.get('/test/blob/sources/f/testfoo.jpg') @@ -912,12 +890,12 @@ class PagureFlaskRepotests(tests.Modeltests): output = self.app.get('/fork/pingou/test3/blob/master/f/sources') self.assertEqual(output.status_code, 200) - self.assertTrue('
    ' in output.data) - self.assertTrue( - '
    ' - in output.data) - self.assertTrue( - '' in output.data) + self.assertIn('
     barRow 0
    ', output.data) + self.assertIn( + '', + output.data) + self.assertIn( + '', output.data) def test_view_raw_file(self): """ Test the view_raw_file endpoint. """ @@ -1253,7 +1231,8 @@ index 0000000..fb7093d output = self.app.get('/test/tree/') self.assertEqual(output.status_code, 200) self.assertTrue( - '

    \n None/

    ' in output.data) + '
  • ' + '  None
  • ' in output.data) self.assertTrue( 'No content found in this repository' in output.data) @@ -1266,7 +1245,7 @@ index 0000000..fb7093d output = self.app.get('/test/tree/%s' % commit.oid.hex) self.assertEqual(output.status_code, 200) self.assertTrue('

    test project #1

    ' in output.data) - self.assertTrue('

    Tree

    ' in output.data) + self.assertIn('Tree - test - Pagure', output.data) self.assertTrue('README.rst' in output.data) self.assertFalse( 'No content found in this repository' in output.data) @@ -1275,7 +1254,7 @@ index 0000000..fb7093d output = self.app.get('/test/tree/master') self.assertEqual(output.status_code, 200) self.assertTrue('

    test project #1

    ' in output.data) - self.assertTrue('

    Tree

    ' in output.data) + self.assertIn('Tree - test - Pagure', output.data) self.assertTrue('README.rst' in output.data) self.assertFalse( 'No content found in this repository' in output.data) @@ -1297,7 +1276,7 @@ index 0000000..fb7093d output = self.app.get('/fork/pingou/test3/tree/') self.assertEqual(output.status_code, 200) self.assertTrue('

    test project #3

    ' in output.data) - self.assertTrue('

    Tree

    ' in output.data) + self.assertIn('Tree - test3 - Pagure', output.data) self.assertTrue( '' in output.data) @@ -1339,11 +1318,16 @@ index 0000000..fb7093d ast.return_value = False output = self.app.post('/test/delete', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue( - '
  • Could not delete all the repos from the ' - 'system
  • ' in output.data) - self.assertTrue('

    Projects (1)

    ' in output.data) - self.assertTrue('

    Forks (0)

    ' in output.data) + self.assertIn( + '\n Could not delete all the ' + 'repos from the system', output.data) + self.assertIn( + '

    Projects 1

    ', output.data) + self.assertIn( + '
    ' + '0
    ', + output.data) # Only git repo item = pagure.lib.model.Project( @@ -1358,10 +1342,15 @@ index 0000000..fb7093d output = self.app.post('/test/delete', follow_redirects=True) self.assertEqual(output.status_code, 200) self.assertTrue( - '
  • Could not delete all the repos from the ' - 'system
  • ' in output.data) - self.assertTrue('

    Projects (1)

    ' in output.data) - self.assertTrue('

    Forks (0)

    ' in output.data) + '\n Could not delete all the ' + 'repos from the system' in output.data) + self.assertIn( + '

    Projects 1

    ', output.data) + self.assertIn( + '
    ' + '0
    ', + output.data) # Only git and doc repo item = pagure.lib.model.Project( @@ -1377,8 +1366,8 @@ index 0000000..fb7093d output = self.app.post('/test/delete', follow_redirects=True) self.assertEqual(output.status_code, 200) self.assertTrue( - '
  • Could not delete all the repos from the ' - 'system
  • ' in output.data) + '\n Could not delete all the ' + 'repos from the system' in output.data) # All repo there item = pagure.lib.model.Project( @@ -1479,8 +1468,13 @@ index 0000000..fb7093d output = self.app.post('/test/delete', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('

    Projects (1)

    ' in output.data) - self.assertTrue('

    Forks (0)

    ' in output.data) + self.assertIn( + '

    Projects 1

    ', output.data) + self.assertIn( + '
    ' + '0
    ', + output.data) repo = pagure.lib.get_project(self.session, 'test') self.assertEqual(repo, None) @@ -1507,8 +1501,13 @@ index 0000000..fb7093d output = self.app.post( '/fork/pingou/test3/delete', follow_redirects=True) self.assertEqual(output.status_code, 200) - self.assertTrue('

    Projects (1)

    ' in output.data) - self.assertTrue('

    Forks (0)

    ' in output.data) + self.assertIn( + '

    Projects 1

    ', output.data) + self.assertIn( + '
    ' + '0
    ', + output.data) @patch('pagure.ui.repo.admin_session_timedout') def test_new_repo_hook_token(self, ast): @@ -1524,7 +1523,7 @@ index 0000000..fb7093d pagure.APP.config['WEBHOOK'] = True output = self.app.get('/new/') self.assertEqual(output.status_code, 200) - self.assertTrue('

    New project

    ' in output.data) + self.assertIn('Create new Project', output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -1561,7 +1560,7 @@ index 0000000..fb7093d '/test/hook_token', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) self.assertIn( - '
  • New hook token generated
  • ', + '\n New hook token generated', output.data) pagure.APP.config['WEBHOOK'] = False @@ -1582,7 +1581,7 @@ index 0000000..fb7093d with tests.user_set(pagure.APP, user): output = self.app.get('/new/') self.assertEqual(output.status_code, 200) - self.assertTrue('

    New project

    ' in output.data) + self.assertIn('Create new Project', output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -1631,7 +1630,7 @@ index 0000000..fb7093d '/test/regenerate', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) self.assertIn( - '
  • Tickets git repo updated
  • ', + '\n Tickets git repo updated', output.data) # Create a request to play with @@ -1654,7 +1653,7 @@ index 0000000..fb7093d '/test/regenerate', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) self.assertIn( - '
  • Requests git repo updated
  • ', + '\n Requests git repo updated', output.data) def test_view_tags(self): @@ -1735,11 +1734,14 @@ index 0000000..fb7093d output = self.app.get('/test/edit/master/f/sources') self.assertEqual(output.status_code, 200) self.assertIn( - '
    master/sources', + '
  • ' + '  master' + '
  • ' + '  sources
  • ', output.data) self.assertIn( - '', + output.data) csrf_token = output.data.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -1793,7 +1795,8 @@ index 0000000..fb7093d self.assertIn( 'Logs - test - Pagure', output.data) self.assertIn( - '
  • Changes committed
  • ', output.data) + '\n Changes committed', + output.data) # Check file after the commit: output = self.app.get('/test/raw/master/f/sources') @@ -1822,11 +1825,14 @@ index 0000000..fb7093d output = self.app.get('/fork/pingou/test3/edit/master/f/sources') self.assertEqual(output.status_code, 200) self.assertIn( - '' - 'master/sources', output.data) + '
  • ' + '  master' + '
  • ' + '  sources' + '
  • ', output.data) self.assertIn( - '
     barRow 0