From f7b10e124289426fc7ab6b888b1f69967f10224e Mon Sep 17 00:00:00 2001 From: Clement Verna Date: Aug 11 2017 14:35:53 +0000 Subject: Make the API returns only open issues by default. Fixes #2468 Signed-off-by: Clement Verna --- diff --git a/pagure/api/issue.py b/pagure/api/issue.py index d7bd0b3..1768f56 100644 --- a/pagure/api/issue.py +++ b/pagure/api/issue.py @@ -437,6 +437,8 @@ def api_view_issues(repo, username=None, namespace=None): params.update({'closed': True}) else: params.update({'status': status}) + else: + params.update({'status': 'Open'}) updated_after = None if since: diff --git a/tests/test_pagure_flask_api_issue.py b/tests/test_pagure_flask_api_issue.py index 2caa287..c7f525a 100644 --- a/tests/test_pagure_flask_api_issue.py +++ b/tests/test_pagure_flask_api_issue.py @@ -45,7 +45,7 @@ FULL_ISSUE_LIST = [ "milestone": "", "priority": None, "private": True, - "status": "Open", + "status": "Closed", "tags": [], "title": "Test issue", "user": { @@ -298,7 +298,6 @@ class PagureFlaskApiIssuetests(tests.Modeltests): pagure.APP.config['TICKETS_FOLDER'] = None - def test_api_new_issue(self): """ Test the api_new_issue method of the flask api. """ tests.create_projects(self.session) @@ -848,7 +847,8 @@ class PagureFlaskApiIssuetests(tests.Modeltests): user='pingou', ticketfolder=None, private=True, - milestone="" + milestone="", + status="Closed" ) self.session.commit() self.assertEqual(msg.title, 'Test issue') @@ -943,8 +943,8 @@ class PagureFlaskApiIssuetests(tests.Modeltests): "status": None, "tags": [] }, - "issues": FULL_ISSUE_LIST, - "total_issues": 9 + "issues": FULL_ISSUE_LIST[1:], + "total_issues": 8 } ) headers = {'Authorization': 'token aaabbbccc'} @@ -1012,8 +1012,8 @@ class PagureFlaskApiIssuetests(tests.Modeltests): "status": None, "tags": [] }, - "issues": FULL_ISSUE_LIST, - "total_issues": 9 + "issues": FULL_ISSUE_LIST[1:], + "total_issues": 8 } ) @@ -1021,21 +1021,23 @@ class PagureFlaskApiIssuetests(tests.Modeltests): output = self.app.get('/api/0/test/issues?status=Closed', headers=headers) self.assertEqual(output.status_code, 200) data = json.loads(output.data) + data['issues'][0]['date_created'] = '1431414800' + data['issues'][0]['last_updated'] = '1431414800' self.assertDictEqual( data, { "args": { "assignee": None, "author": None, - 'milestones': [], - 'no_stones': None, - 'priority': None, + "milestones": [], + "no_stones": None, + "priority": None, "since": None, "status": "Closed", "tags": [] }, - "total_issues": 0, - "issues": [] + "issues": [FULL_ISSUE_LIST[0]], + "total_issues": 1, } )