diff --git a/pagure/ui/app.py b/pagure/ui/app.py index 3fa8560..cabee76 100644 --- a/pagure/ui/app.py +++ b/pagure/ui/app.py @@ -897,7 +897,8 @@ def add_api_user_token(): ) flask.g.session.commit() flask.flash(msg) - return flask.redirect(flask.url_for('ui_ns.user_settings')+"#nav-api-tab") + return flask.redirect( + flask.url_for('ui_ns.user_settings') + "#nav-api-tab") except SQLAlchemyError as err: # pragma: no cover flask.g.session.rollback() _log.exception(err) @@ -949,7 +950,8 @@ def revoke_api_user_token(token_id): 'Token could not be revoked, please contact an admin', 'error') - return flask.redirect(flask.url_for('ui_ns.user_settings')+"#nav-api-token") + return flask.redirect( + flask.url_for('ui_ns.user_settings') + "#nav-api-token") @UI_NS.route('/settings/forcelogout/', methods=('POST', )) diff --git a/pagure/ui/filters.py b/pagure/ui/filters.py index 69c3440..e725fa1 100644 --- a/pagure/ui/filters.py +++ b/pagure/ui/filters.py @@ -383,7 +383,7 @@ def avatar(packager, size=64, css_class=None): class_string = "avatar circle" if css_class: - class_string = class_string+" "+css_class + class_string = class_string + " " + css_class output = '' % ( class_string, diff --git a/pagure/ui/repo.py b/pagure/ui/repo.py index 3e1e45c..c77a452 100644 --- a/pagure/ui/repo.py +++ b/pagure/ui/repo.py @@ -183,6 +183,7 @@ def view_repo(repo, username=None, namespace=None): git_url_ssh=get_git_url_ssh(), ) + """ @UI_NS.route('//branch/') @UI_NS.route('///branch/') @@ -279,6 +280,7 @@ def view_repo_branch(repo, branchname, username=None, namespace=None): ) """ + @UI_NS.route('//commits/') @UI_NS.route('//commits') @UI_NS.route('//commits/') @@ -987,6 +989,7 @@ def view_tags(repo, username=None, namespace=None): pagure_checksum=pagure_checksum, ) + @UI_NS.route('//branches/') @UI_NS.route('//branches') @UI_NS.route('///branches/') @@ -1022,7 +1025,6 @@ def view_branches(repo, username=None, namespace=None): ) - @UI_NS.route('//upload/', methods=('GET', 'POST')) @UI_NS.route('//upload', methods=('GET', 'POST')) @UI_NS.route('///upload/', methods=('GET', 'POST')) diff --git a/tests/test_pagure_flask_ui_plugins.py b/tests/test_pagure_flask_ui_plugins.py index 7adcf69..9be60aa 100644 --- a/tests/test_pagure_flask_ui_plugins.py +++ b/tests/test_pagure_flask_ui_plugins.py @@ -110,11 +110,13 @@ class PagureFlaskPluginstests(tests.SimplePagureTest): output = self.app.post( '/test/settings/Mail', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) + output_text = output.get_data(as_text=True) self.assertIn( - '
\n

Settings for test

', - output.get_data(as_text=True)) + '
' + 'Project Settings
\n', output_text) self.assertIn( - '\n Hook Mail activated', output.get_data(as_text=True)) + '\n Hook Mail activated', + output_text) data = { 'mail_to': '', @@ -124,11 +126,13 @@ class PagureFlaskPluginstests(tests.SimplePagureTest): output = self.app.post( '/test/settings/Mail', data=data, follow_redirects=True) self.assertEqual(output.status_code, 200) + output_text = output.get_data(as_text=True) self.assertIn( - '
\n

Settings for test

', - output.get_data(as_text=True)) + '
' + 'Project Settings
\n', output_text) self.assertIn( - '\n Hook Mail deactivated', output.get_data(as_text=True)) + '\n Hook Mail deactivated', + output_text) def test_RequiredIf(self): """ Test the behavior of the RequiredIf validator. """ diff --git a/tests/test_pagure_flask_ui_plugins_pagure_request_hook.py b/tests/test_pagure_flask_ui_plugins_pagure_request_hook.py index adc9746..3ba2be4 100644 --- a/tests/test_pagure_flask_ui_plugins_pagure_request_hook.py +++ b/tests/test_pagure_flask_ui_plugins_pagure_request_hook.py @@ -39,7 +39,7 @@ class PagureFlaskPluginPagureRequestHooktests(tests.SimplePagureTest): self.assertEqual(output.status_code, 200) output_text = output.get_data(as_text=True) self.assertIn( - 'Settings Pagure request - test - Pagure', + 'Settings Pagure requests - test - Pagure', output_text) self.assertIn( 'Settings Pagure request - test - Pagure', + 'Settings Pagure requests - test - Pagure', output_text) self.assertIn( 'Settings Pagure request - test - Pagure', + 'Settings Pagure requests - test - Pagure', output_text) self.assertIn( 'Settings Pagure request - test - Pagure', + 'Settings Pagure requests - test - Pagure', output_text) self.assertIn( 'Settings Pagure request - test - Pagure', + 'Settings Pagure requests - test - Pagure', output_text) self.assertIn( ' @@ -155,7 +155,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -171,7 +173,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- None, no CSRF repo = pagure.lib.get_authorized_project(self.session, 'test') self.assertEqual(repo.priorities, {}) @@ -188,7 +192,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() repo = pagure.lib.get_authorized_project(self.session, 'test') @@ -206,7 +212,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the ordering self.assertTrue( output_text.find('High') < output_text.find('Normal')) @@ -233,7 +241,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n' ' Priorities weights and titles are ' @@ -259,7 +269,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n' ' Priorities weights must be numbers', @@ -285,7 +297,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n' ' Priority weight 2 is present 2 times', @@ -311,7 +325,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n' ' Priority Normal is present 2 times', @@ -377,7 +393,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -394,7 +412,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() @@ -442,7 +462,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check that the issue list renders fine output = self.app.get('/test/issues') @@ -485,7 +507,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -502,7 +526,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() @@ -551,7 +577,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check that the issue list renders fine output = self.app.get('/test/issues') @@ -592,7 +620,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -610,7 +640,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() @@ -722,7 +754,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -740,7 +774,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() @@ -830,7 +866,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) csrf_token = output_text.split( 'name="csrf_token" type="hidden" value="')[1].split('">')[0] @@ -848,7 +886,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): output_text = output.get_data(as_text=True) self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- Priority recorded self.session.commit() @@ -946,7 +986,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the ordering self.assertTrue( output_text.find('High') < output_text.find('Normal')) @@ -970,7 +1012,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- default_priority no change self.session.commit() repo = pagure.lib.get_authorized_project(self.session, 'test') @@ -986,7 +1030,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n Default priority set ' 'to High', output_text) @@ -1005,7 +1051,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the result of the action -- default_priority no change self.session.commit() repo = pagure.lib.get_authorized_project(self.session, 'test') @@ -1021,7 +1069,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n Default priority reset', output_text) @@ -1092,7 +1142,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) # Check the ordering self.assertTrue( output_text.find('High') < output_text.find('Normal')) @@ -1116,7 +1168,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n Default priority set ' 'to High', output_text) @@ -1138,7 +1192,9 @@ class PagureFlaskPrioritiestests(tests.Modeltests): # Check the redirect self.assertIn( 'Settings - test - Pagure', output_text) - self.assertIn('

Settings for test

', output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) self.assertIn( '\n Priorities updated', output_text) diff --git a/tests/test_pagure_flask_ui_quick_reply.py b/tests/test_pagure_flask_ui_quick_reply.py index e45b19f..0fc4efd 100644 --- a/tests/test_pagure_flask_ui_quick_reply.py +++ b/tests/test_pagure_flask_ui_quick_reply.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """ - (c) 2015-2016 - Copyright Red Hat Inc + (c) 2015-2018 - Copyright Red Hat Inc Authors: Lubomír Sedlář @@ -74,11 +74,15 @@ class PagureFlaskQuickReplytest(tests.Modeltests): and that a given notice was printed. """ self.assertEqual(output.status_code, 200) + output_text = output.get_data(as_text=True) self.assertIn( - 'Settings - %s - Pagure' % project, output.get_data(as_text=True)) - self.assertIn('

Settings for %s

' % project, output.get_data(as_text=True)) + 'Settings - %s - Pagure' % project, + output_text) + self.assertIn( + '
' + 'Project Settings
\n', output_text) if notice: - self.assertIn(notice, output.get_data(as_text=True)) + self.assertIn(notice, output_text) def assertQuickReplies(self, quick_replies, project='test'): self.session.commit() diff --git a/tests/test_pagure_flask_ui_repo.py b/tests/test_pagure_flask_ui_repo.py index 88d40c4..0f7442b 100644 --- a/tests/test_pagure_flask_ui_repo.py +++ b/tests/test_pagure_flask_ui_repo.py @@ -790,7 +790,8 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertIn( 'Overview - test - Pagure', output_text) self.assertIn( - '

\ntest', + '

\ntest' + '\n

', output_text) self.assertIn( '\n User removed', output_text) @@ -1241,9 +1242,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertIn( 'Overview - test - Pagure', output_text) self.assertIn( - '
\n' - 'test project #1
', output_text) - self.assertIn( '\n Edited successfully ' 'settings of repo: test', output_text) @@ -1273,9 +1271,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertIn( 'Overview - test - Pagure', output_text) self.assertIn( - '
\n' - 'test project #1
', output_text) - self.assertIn( '\n Edited successfully ' 'settings of repo: test', output_text) @@ -1325,9 +1320,6 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertIn( 'Overview - test - Pagure', output_text) self.assertIn( - '
\n' - 'test project #1
', output_text) - self.assertIn( '\n Edited successfully ' 'settings of repo: test', output_text) @@ -1402,18 +1394,16 @@ class PagureFlaskRepotests(tests.Modeltests): self.assertIn('
Project Settings
', output_text) # Check that the priorities have their empty fields self.assertIn( - '''
-
-
- -
-
- -
-
-
''', output_text) + '''
+
- - + +
@@ -1442,39 +1430,36 @@ class PagureFlaskRepotests(tests.Modeltests): # Check that the close_status have its empty field self.assertIn( - '''
-
-
- -
-
''', output_text) + '''
+