diff --git a/tests/test_progit_flask_internal.py b/tests/test_progit_flask_internal.py index 16fe40f..8f6b80a 100644 --- a/tests/test_progit_flask_internal.py +++ b/tests/test_progit_flask_internal.py @@ -11,12 +11,13 @@ __requires__ = ['SQLAlchemy >= 0.8'] import pkg_resources +import json import unittest import shutil import sys import os -import json +import pygit2 from mock import patch sys.path.insert(0, os.path.join(os.path.dirname( @@ -34,10 +35,16 @@ class PagureFlaskInternaltests(tests.Modeltests): super(PagureFlaskInternaltests, self).setUp() pagure.APP.config['TESTING'] = True - pagure.APP.config['IP_ALLOWED_INTERNAL'].append(None) + pagure.APP.config['IP_ALLOWED_INTERNAL'] = list(set( + pagure.APP.config['IP_ALLOWED_INTERNAL'] + [None])) pagure.SESSION = self.session pagure.internal.SESSION = self.session + pagure.APP.config['GIT_FOLDER'] = tests.HERE + pagure.APP.config['FORK_FOLDER'] = os.path.join( + tests.HERE, 'forks') pagure.APP.config['REQUESTS_FOLDER'] = None + pagure.APP.config['TICKETS_FOLDER'] = None + pagure.APP.config['DOCS_FOLDER'] = None self.app = pagure.APP.test_client() @patch('pagure.lib.notify.send_email') @@ -276,6 +283,127 @@ class PagureFlaskInternaltests(tests.Modeltests): output = self.app.put('/pv/ticket/comment/', data=data) self.assertEqual(output.status_code, 403) + @patch('pagure.lib.notify.send_email') + def test_mergeable_request_pull_FF(self, send_email): + """ Test the mergeable_request_pull endpoint with a fast-forward + merge. + """ + send_email.return_value = True + + # Create a git repo to play with + + gitrepo = os.path.join(tests.HERE, 'test.git') + self.assertFalse(os.path.exists(gitrepo)) + os.makedirs(gitrepo) + repo = pygit2.init_repository(gitrepo) + + # Create a file in that git repo + with open(os.path.join(gitrepo, 'sources'), 'w') as stream: + stream.write('foo\n bar') + repo.index.add('sources') + repo.index.write() + + # Commits the files added + tree = repo.index.write_tree() + author = pygit2.Signature( + 'Alice Author', 'alice@authors.tld') + committer = pygit2.Signature( + 'Cecil Committer', 'cecil@committers.tld') + repo.create_commit( + 'refs/heads/master', # the name of the reference to update + author, + committer, + 'Add sources file for testing', + # binary string representing the tree object ID + tree, + # list of binary strings representing parents of the new commit + [] + ) + + first_commit = repo.revparse_single('HEAD') + + # Edit the sources file again + with open(os.path.join(gitrepo, 'sources'), 'w') as stream: + stream.write('foo\n bar\nbaz\n boose') + repo.index.add('sources') + repo.index.write() + + # Commits the files added + tree = repo.index.write_tree() + author = pygit2.Signature( + 'Alice Author', 'alice@authors.tld') + committer = pygit2.Signature( + 'Cecil Committer', 'cecil@committers.tld') + repo.create_commit( + 'refs/heads/feature', # the name of the reference to update + author, + committer, + 'Add baz and boose to the sources\n\n There are more objects to ' + 'consider', + # binary string representing the tree object ID + tree, + # list of binary strings representing parents of the new commit + [first_commit.oid.hex] + ) + + second_commit = repo.revparse_single('HEAD') + + # Create a PR for these changes + tests.create_projects(self.session) + project = pagure.lib.get_project(self.session, 'test') + msg = pagure.lib.new_pull_request( + session=self.session, + repo_from=project, + branch_from='feature', + repo_to=project, + branch_to='master', + title='PR from the feature branch', + user='pingou', + requestfolder=None, + ) + self.session.commit() + self.assertEqual(msg, 'Request created') + + # Check if the PR can be merged + data = { + 'objid': 'blah', + } + + # Missing CSRF + output = self.app.post('/pv/pull-request/merge', data=data) + self.assertEqual(output.status_code, 400) + + user = tests.FakeUser() + user.username = 'pingou' + with tests.user_set(pagure.APP, user): + output = self.app.get('/test/adduser') + csrf_token = output.data.split( + 'name="csrf_token" type="hidden" value="')[1].split('">')[0] + + # Missing request identifier + data = { + 'csrf_token': csrf_token, + } + output = self.app.post('/pv/pull-request/merge', data=data) + self.assertEqual(output.status_code, 404) + + # With all the desired information + project = pagure.lib.get_project(self.session, 'test') + data = { + 'csrf_token': csrf_token, + 'requestid': project.requests[0].uid, + } + output = self.app.post('/pv/pull-request/merge', data=data) + self.assertEqual(output.status_code, 200) + exp = { + "code": "FFORWARD", + "message": "The pull-request can be merged and fast-forwarded", + "short_code": "Ok" + } + + js_data = json.loads(output.data) + self.assertDictEqual(js_data, exp) + if __name__ == '__main__': SUITE = unittest.TestLoader().loadTestsFromTestCase(