diff --git a/tests/test_progit_flask_ui_groups.py b/tests/test_progit_flask_ui_groups.py
index 99f865c..c04a1cb 100644
--- a/tests/test_progit_flask_ui_groups.py
+++ b/tests/test_progit_flask_ui_groups.py
@@ -100,15 +100,25 @@ class PagureFlaskGroupstests(tests.Modeltests):
data['csrf_token'] = csrf_token
+ # Space in the group
+ output = self.app.post(
+ '/group/add', data=data)
+ self.assertEqual(output.status_code, 200)
+ self.assertIn('
Create group
', output.data)
+ self.assertIn(
+ 'Spaces are not allowed in group names: '
+ 'test group' , output.data)
+
# All good
+ data['group_name'] = 'test_group'
output = self.app.post(
'/group/add', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'User `pingou` added to the group '
- '`test group`.', output.data)
+ '`test_group`.', output.data)
self.assertIn(
- 'Group `test group` created.',
+ 'Group `test_group` created.',
output.data)
self.assertIn('Groups
', output.data)
self.assertIn('1 groups.
', output.data)
@@ -123,7 +133,7 @@ class PagureFlaskGroupstests(tests.Modeltests):
self.assertIn('', output.data)
data = {
- 'group_name': 'test admin group',
+ 'group_name': 'test_admin_group',
'group_type': 'admin',
'csrf_token': csrf_token,
}
@@ -134,9 +144,9 @@ class PagureFlaskGroupstests(tests.Modeltests):
self.assertEqual(output.status_code, 200)
self.assertIn(
'User `pingou` added to the group '
- '`test admin group`.', output.data)
+ '`test_admin_group`.', output.data)
self.assertIn(
- 'Group `test admin group` created.',
+ 'Group `test_admin_group` created.',
output.data)
self.assertIn('Groups
', output.data)
self.assertIn('2 groups.
', output.data)
@@ -179,28 +189,28 @@ class PagureFlaskGroupstests(tests.Modeltests):
self.assertIn('1 groups.
', output.data)
output = self.app.post(
- '/group/test group/delete', data=data, follow_redirects=True)
+ '/group/test_group/delete', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'You are not allowed to delete the group '
- 'test group', output.data)
+ 'test_group', output.data)
self.assertIn('1 groups.
', output.data)
user.username = 'bar'
with tests.user_set(pagure.APP, user):
output = self.app.post(
- '/group/test group/delete', data=data, follow_redirects=True)
+ '/group/test_group/delete', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post(
- '/group/test group/delete', data=data, follow_redirects=True)
+ '/group/test_group/delete', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
- 'Group `test group` has been deleted'
+ 'Group `test_group` has been deleted'
'', output.data)
self.assertIn('0 groups.
', output.data)
@@ -213,11 +223,11 @@ class PagureFlaskGroupstests(tests.Modeltests):
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
- output = self.app.get('/group/test group')
+ output = self.app.get('/group/test_group')
self.assertEqual(output.status_code, 200)
- self.assertIn('Group: test group
', output.data)
+ self.assertIn('Group: test_group
', output.data)
- output = self.app.get('/group/test admin group')
+ output = self.app.get('/group/test_admin_group')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser(
@@ -225,9 +235,9 @@ class PagureFlaskGroupstests(tests.Modeltests):
groups=pagure.APP.config['ADMIN_GROUP'])
with tests.user_set(pagure.APP, user):
# Admin can see group of type admins
- output = self.app.get('/group/test admin group')
+ output = self.app.get('/group/test_admin_group')
self.assertEqual(output.status_code, 200)
- self.assertIn('Group: test admin group
', output.data)
+ self.assertIn('Group: test_admin_group
', output.data)
self.assertEqual(output.data.count('No user `bar` found', output.data)
- self.assertIn('Group: test admin group
', output.data)
+ self.assertIn('Group: test_admin_group
', output.data)
self.assertEqual(output.data.count('User `foo` added to the group `test '
- 'admin group`.', output.data)
- self.assertIn('Group: test admin group
', output.data)
+ 'User `foo` added to the group '
+ '`test_admin_group`.', output.data)
+ self.assertIn('Group: test_admin_group
', output.data)
self.assertEqual(output.data.count('No user `bar` found', output.data)
- self.assertIn('Group: test group
', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('Could not find user username',
output.data)
- self.assertIn('Group: test group
', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('User `foo` could not be found in the '
- 'group `test group`', output.data)
- self.assertIn('Group: test group
', output.data)
+ 'group `test_group`', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('User `foo` could not be found in the '
- 'group `test group`', output.data)
- self.assertIn('Group: test group
', output.data)
+ 'group `test_group`', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('User `foo` added to the group `test '
- 'group`.', output.data)
- self.assertIn('Group: test group
', output.data)
+ 'User `foo` added to the group '
+ '`test_group`.', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('User `foo` removed from the group '
- '`test group`', output.data)
- self.assertIn('Group: test group
', output.data)
+ '`test_group`', output.data)
+ self.assertIn('Group: test_group
', output.data)
self.assertEqual(output.data.count('