diff --git a/pagure/ui/issues.py b/pagure/ui/issues.py index afd5bea..51676b6 100644 --- a/pagure/ui/issues.py +++ b/pagure/ui/issues.py @@ -472,13 +472,10 @@ def update_tags(repo, username=None, namespace=None): ] # Uniquify and order preserving - seen = set() colors = [ col.strip() for col in flask.request.form.getlist('tag_color') if col.strip() - and col.strip() not in seen - and not seen.add(col.strip()) ] color_pattern = re.compile('^#\w{3,6}$') diff --git a/tests/test_pagure_flask_ui_issues.py b/tests/test_pagure_flask_ui_issues.py index 15f78a7..fe46be1 100644 --- a/tests/test_pagure_flask_ui_issues.py +++ b/tests/test_pagure_flask_ui_issues.py @@ -3364,8 +3364,8 @@ class PagureFlaskIssuestests(tests.Modeltests): self.assertIn( 'blue\n' - ' ' - '', output.data) + ' ', + output.data) self.assertIn( '', output.data) @@ -3407,9 +3407,40 @@ class PagureFlaskIssuestests(tests.Modeltests): '', output.data) + # Valid query - Two tags of the same color + data = { + 'tag': ['red2', 'red3'], + 'tag_color': ['#ff0000', '#ff0000'], + 'tag_description': ['', ''], + 'csrf_token': csrf_token, + } + output = self.app.post( + '/test/update/tags', data=data, follow_redirects=True) + self.assertEqual(output.status_code, 200) + self.assertIn( + '