diff --git a/pagure/templates/roadmap.html b/pagure/templates/roadmap.html index 0825134..4990cbf 100644 --- a/pagure/templates/roadmap.html +++ b/pagure/templates/roadmap.html @@ -151,10 +151,14 @@ {% for milestone in milestones %}
- +
- + {% if status and status|lower != 'open' %} @@ -179,11 +183,6 @@ status=status) }}">reset) {% endif %} - {% if repo.milestones[milestone] %} - - Due: {{ repo.milestones[milestone] }} - - {% endif %} @@ -194,15 +193,6 @@
Milestone: {{ milestone }}Milestone: {{ milestone }} + {% if repo.milestones[milestone] %} +   (Due: {{ repo.milestones[milestone] }}) + {% endif %} + OpenedClosedStatus
#{{ issue.id }} - {% if status is none or status != 'Open' %} - {{issue.close_status}} - {% endif %} {% if issue.private %} {% endif %} diff --git a/pagure/ui/issues.py b/pagure/ui/issues.py index e192a7e..ca1067b 100644 --- a/pagure/ui/issues.py +++ b/pagure/ui/issues.py @@ -249,7 +249,7 @@ def update_issue(repo, issueid, username=None, namespace=None): ticketfolder=APP.config['TICKETS_FOLDER'], ) SESSION.commit() - if message and message != 'Nothing to change': + if message: messages.add(message) # Update priority @@ -705,13 +705,12 @@ def view_roadmap(repo, username=None, namespace=None): requested_stones = None if milestone is not None: requested_stones = milestone - milestones = milestone or list(repo.milestones.keys()) all_milestones = list(repo.milestones.keys()) issues = pagure.lib.search_issues( SESSION, repo, - milestones=milestones, + milestones=milestone or list(repo.milestones.keys()), tags=tags, private=private, ) @@ -720,7 +719,7 @@ def view_roadmap(repo, username=None, namespace=None): milestone_issues = defaultdict(list) for cnt in range(len(issues)): saved = False - for mlstone in sorted(milestones): + for mlstone in sorted(milestone or list(repo.milestones.keys())): if mlstone == issues[cnt].milestone: milestone_issues[mlstone].append(issues[cnt]) saved = True diff --git a/tests/test_pagure_flask_ui_roadmap.py b/tests/test_pagure_flask_ui_roadmap.py index c01da82..8053e8a 100644 --- a/tests/test_pagure_flask_ui_roadmap.py +++ b/tests/test_pagure_flask_ui_roadmap.py @@ -162,7 +162,6 @@ class PagureFlaskRoadmaptests(tests.Modeltests): 'href="/test/issue/1/edit" title="Edit this issue">', output.data) - def test_update_milestones(self): """ Test updating milestones of a repo. """ tests.create_projects(self.session) @@ -482,7 +481,6 @@ class PagureFlaskRoadmaptests(tests.Modeltests): # test the roadmap view output = self.app.get('/test/roadmap') self.assertEqual(output.status_code, 200) - self.assertIn(u'2 Milestones', output.data) self.assertIn(u'Milestone: v2.0', output.data) self.assertIn(u'Milestone: unplanned', output.data) self.assertEqual( @@ -491,7 +489,6 @@ class PagureFlaskRoadmaptests(tests.Modeltests): # test the roadmap view for all milestones output = self.app.get('/test/roadmap?status=All') self.assertEqual(output.status_code, 200) - self.assertIn(u'3 Milestones', output.data) self.assertIn(u'Milestone: v1.0', output.data) self.assertIn(u'Milestone: v2.0', output.data) self.assertIn(u'Milestone: unplanned', output.data) @@ -501,27 +498,31 @@ class PagureFlaskRoadmaptests(tests.Modeltests): # test the roadmap view for a specific milestone output = self.app.get('/test/roadmap?milestone=v2.0') self.assertEqual(output.status_code, 200) - self.assertIn(u'1 Milestones', output.data) self.assertIn(u'Milestone: v2.0', output.data) self.assertEqual( output.data.count(u'#'), 2) - # test the roadmap view for a specific milestone - closed + # test the roadmap view for a specific milestone - open output = self.app.get('/test/roadmap?milestone=v1.0') self.assertEqual(output.status_code, 200) - self.assertIn(u'1 Milestones', output.data) - self.assertIn(u'Milestone: v1.0', output.data) + self.assertIn(u'No issues found', output.data) self.assertEqual( output.data.count(u'#'), 0) # test the roadmap view for a specific milestone - closed output = self.app.get('/test/roadmap?milestone=v1.0&status=All') self.assertEqual(output.status_code, 200) - self.assertIn(u'1 Milestones', output.data) self.assertIn(u'Milestone: v1.0', output.data) self.assertEqual( output.data.count(u'#'), 2) + # test the roadmap view for a specific tag + output = self.app.get('/test/roadmap?milestone=v2.0&tag=unknown') + self.assertEqual(output.status_code, 200) + self.assertIn(u'No issues found', output.data) + self.assertEqual( + output.data.count(u'#'), 0) + # test the roadmap view for errors output = self.app.get('/foo/roadmap') self.assertEqual(output.status_code, 404)