# -*- coding: utf-8 -*-
"""
(c) 2015-2017 - Copyright Red Hat Inc
Authors:
Pierre-Yves Chibon <pingou@pingoured.fr>
"""
__requires__ = ['SQLAlchemy >= 0.8']
import pkg_resources
from unittest.case import SkipTest
import json
import unittest
import shutil
import sys
import os
try:
import pyclamd
except ImportError:
pyclamd = None
import tempfile
import pygit2
from mock import patch
sys.path.insert(0, os.path.join(os.path.dirname(
os.path.abspath(__file__)), '..'))
import pagure.lib
import tests
class PagureFlaskIssuestests(tests.Modeltests):
""" Tests for flask issues controller of pagure """
def setUp(self):
""" Set up the environnment, run before every tests. """
super(PagureFlaskIssuestests, self).setUp()
pagure.APP.config['TESTING'] = True
# TODO: Figure a way to enable this test on jenkins
if not os.environ.get('BUILD_ID'):
pagure.APP.config['VIRUS_SCAN_ATTACHMENTS'] = True
pagure.SESSION = self.session
pagure.ui.SESSION = self.session
pagure.ui.app.SESSION = self.session
pagure.ui.issues.SESSION = self.session
pagure.ui.repo.SESSION = self.session
pagure.ui.filters.SESSION = self.session
pagure.APP.config['GIT_FOLDER'] = self.path
pagure.APP.config['TICKETS_FOLDER'] = os.path.join(
self.path, 'tickets')
pagure.APP.config['DOCS_FOLDER'] = os.path.join(
self.path, 'docs')
self.app = pagure.APP.test_client()
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_new_issue(self, p_send_email, p_ugt):
""" Test the new_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.get('/foo/new_issue')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/foo/new_issue')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/new_issue')
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {
}
# Insufficient input
output = self.app.post('/test/new_issue', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
self.assertEqual(output.data.count(
'This field is required.'), 2)
data['title'] = 'Test issue'
output = self.app.post('/test/new_issue', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
self.assertEqual(output.data.count(
'This field is required.'), 1)
data['issue_content'] = 'We really should improve on this issue'
data['status'] = 'Open'
output = self.app.post('/test/new_issue', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
self.assertEqual(output.data.count(
'</button>\n This field is required.'),
0)
# Invalid user
data['csrf_token'] = csrf_token
output = self.app.post('/test/new_issue', data=data)
self.assertEqual(output.status_code, 404)
self.assertIn(
'<p>No such user found in the database: username</p>',
output.data)
# User not logged in
output = self.app.get('/test/new_issue')
self.assertEqual(output.status_code, 302)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/test/new_issue', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/test/new_issue', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_new_issue_w_file(self, p_send_email, p_ugt):
""" Test the new_issue endpoint with a file. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
tests.create_projects_git(
os.path.join(self.path, 'tickets'), bare=True)
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/new_issue')
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
with open(os.path.join(tests.HERE, 'placebo.png'), 'r') as stream:
data = {
'title': 'Test issue',
'issue_content': 'We really should improve on this issue\n'
'<!!image>',
'status': 'Open',
'filestream': stream,
'enctype': 'multipart/form-data',
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/new_issue', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
# Check the image was uploaded
self.assertIn(
'href="/test/issue/raw/files/'
'8a06845923010b27bfd8e7e75acff7badc40d1021b4'
'994e01f5e11ca40bc3abe',
output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
with open(os.path.join(tests.HERE, 'placebo.png'), 'r') as stream:
data = {
'title': 'Test issue',
'issue_content': 'We really should improve on this issue',
'status': 'Open',
'filestream': stream,
'enctype': 'multipart/form-data',
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/new_issue', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
# Project with a namespace
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/somenamespace/test3/new_issue')
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n New issue'
in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
with open(os.path.join(tests.HERE, 'placebo.png'), 'r') as stream:
data = {
'title': 'Test issue3',
'issue_content': 'We really should improve on this issue\n'
'<!!image>',
'status': 'Open',
'filestream': stream,
'enctype': 'multipart/form-data',
'csrf_token': csrf_token,
}
output = self.app.post(
'/somenamespace/test3/new_issue', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue3 - test3 - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/somenamespace/test3/issue/1/edit" '
'title="Edit this issue">',
output.data)
# Check the image was uploaded
self.assertIn(
'href="/somenamespace/test3/issue/raw/files/'
'8a06845923010b27bfd8e7e75acff7badc40d1021b4'
'994e01f5e11ca40bc3abe',
output.data)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_view_issues(self, p_send_email, p_ugt):
""" Test the view_issues endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
output = self.app.get('/foo/issues')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/issues')
self.assertEqual(output.status_code, 200)
self.assertIn(
'div class="projectinfo m-t-1 m-b-1">\ntest project #1 '
'</div>', output.data)
self.assertTrue(
'<h2>\n 0 Open Issues' in output.data)
repo = pagure.lib.get_project(self.session, 'test')
# Create some custom fields to play with
msg = pagure.lib.set_custom_key_fields(
session=self.session,
project=repo,
fields=['test1'],
types=['text'],
data=[None]
)
self.session.commit()
self.assertEqual(msg, 'List of custom fields updated')
cfield = pagure.lib.get_custom_key(
session=self.session,
project=repo,
keyname='test1')
# Create issues to play with
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
msg = pagure.lib.set_custom_key_value(
session=self.session,
issue=msg,
key=cfield,
value='firstissue')
self.session.commit()
self.assertEqual(msg, 'Custom field test1 adjusted to firstissue')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue with milestone',
content='Testing search',
user='pingou',
milestone='1.1',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue with milestone')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test invalid issue',
content='This really is not related',
user='pingou',
status='Closed',
close_status='Invalid',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test invalid issue')
msg = pagure.lib.set_custom_key_value(
session=self.session,
issue=msg,
key=cfield,
value='second issue')
self.session.commit()
self.assertEqual(msg, 'Custom field test1 adjusted to second issue')
# Whole list
output = self.app.get('/test/issues')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertTrue(
'<h2>\n 2 Open Issues' in output.data)
# Status = closed (all but open)
output = self.app.get('/test/issues?status=cloSED')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertTrue(
'<h2>\n 1 Closed Issues' in output.data)
# Status = fixed
output = self.app.get('/test/issues?status=fixed')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertTrue(
'<h2>\n 0 Closed Issues' in output.data)
# Status = Invalid
output = self.app.get('/test/issues?status=Invalid')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertTrue(
'<h2>\n 1 Closed Issues' in output.data)
# All tickets
output = self.app.get('/test/issues?status=all')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertTrue(
'<h2>\n 3 Issues' in output.data)
# Custom key searching
output = self.app.get(
'/test/issues?status=all&search_pattern=test1:firstissue')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('1 Issues', output.data)
# Custom key searching with space
output = self.app.get(
'/test/issues?status=all&search_pattern=test1:"second issue"')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('1 Issues', output.data)
# All tickets - different pagination
before = pagure.APP.config['ITEM_PER_PAGE']
pagure.APP.config['ITEM_PER_PAGE'] = 1
output = self.app.get('/test/issues?status=all')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('<h2>\n 1 Issues (of 3)', output.data)
self.assertIn(
'<li class="active">page 1 of 3</li>', output.data)
# All tickets - filtered for 1 - checking the pagination
output = self.app.get(
'/test/issues?status=all&search_pattern=invalid')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('<h2>\n 1 Issues (of 1)', output.data)
self.assertIn(
'<li class="active">page 1 of 1</li>', output.data)
pagure.APP.config['ITEM_PER_PAGE'] = before
# Search for issues with no milestone MARK
output = self.app.get(
'/test/issues?milestone=none')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('1 Open Issues (of 1)', output.data)
# Search for issues with no milestone and milestone 1.1
output = self.app.get(
'/test/issues?milestone=none&milestone=1.1')
self.assertEqual(output.status_code, 200)
self.assertIn('<title>Issues - test - Pagure</title>', output.data)
self.assertIn('2 Open Issues (of 2)', output.data)
# New issue button is shown
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test')
self.assertEqual(output.status_code, 200)
self.assertIn(
'class="btn btn-success btn-sm">New Issue</a>',
output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
output = self.app.get('/test/issues')
self.assertEqual(output.status_code, 404)
# New issue button is hidden
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test')
self.assertEqual(output.status_code, 200)
self.assertNotIn(
'class="btn btn-success btn-sm">New Issue</a>',
output.data)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_view_issue(self, p_send_email, p_ugt):
""" Test the view_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
output = self.app.get('/foo/issue/1')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 404)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
# Not authentified = No edit
self.assertNotIn(
'<a class="btn btn-primary btn-sm" href="/test/issue/1/edit" '
'title="Edit this issue">',
output.data)
self.assertTrue(
'<a href="/login/?next=http%3A%2F%2Flocalhost%2Ftest%2Fissue%2F1">'
'Login</a>\n to comment on this ticket.'
in output.data)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
# Not author nor admin = No edit
self.assertNotIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertNotIn(
'<button class="btn btn-danger btn-sm" type="submit"',
output.data)
self.assertNotIn('title="Delete this ticket">', output.data)
self.assertFalse(
'<a href="/login/">Login</a> to comment on this ticket.'
in output.data)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'<button class="btn btn-danger btn-sm" type="submit"',
output.data)
self.assertIn('title="Delete this ticket">', output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Create private issue
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None,
private=True,
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Not logged in
output = self.app.get('/test/issue/2')
self.assertEqual(output.status_code, 403)
# Wrong user
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/2')
self.assertEqual(output.status_code, 403)
# reporter
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/2')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #2: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<span class="oi red-icon" data-glyph="lock-locked" '
'title="Private issue"></span>', output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/2/edit" title="Edit this issue">',
output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_view_issue_non_ascii_milestone(self, p_send_email, p_ugt):
""" Test the view_issue endpoint with non-ascii milestone. """
p_send_email.return_value = True
p_ugt.return_value = True
output = self.app.get('/foo/issue/1')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 404)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Add a non-ascii milestone to the issue but project has no milestone
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
message = pagure.lib.edit_issue(
self.session,
issue=issue,
milestone=b'käpy'.decode('utf-8'),
private=False,
user='pingou',
ticketfolder=None
)
self.assertEqual(
message,
[
u'Issue set to the milestone: k\xe4py'
]
)
self.session.commit()
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertNotIn(b'käpy'.decode('utf-8'), output.data)
# Add a non-ascii milestone to the project
repo = pagure.lib.get_project(self.session, 'test')
repo.milestones = {b'käpy'.decode('utf-8'): None}
self.session.add(repo)
self.session.commit()
# View the issue
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(b'käpy'.decode('utf-8'), output.data.decode('utf-8'))
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_view_issue_list_no_data(self, p_send_email, p_ugt):
""" Test the view_issue endpoint when the issue has a custom field
of type list with no data attached. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
repo = pagure.lib.get_project(self.session, 'test')
# Add custom fields to the project
msg = pagure.lib.set_custom_key_fields(
session=self.session,
project=repo,
fields=['test1'],
types=['list'],
data=[None]
)
self.session.commit()
self.assertEqual(msg, 'List of custom fields updated')
# Create issues to play with
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Assign a value to the custom key on that ticket
cfield = pagure.lib.get_custom_key(
session=self.session,
project=repo,
keyname='test1')
msg = pagure.lib.set_custom_key_value(
session=self.session,
issue=msg,
key=cfield,
value='item')
self.session.commit()
self.assertEqual(msg, 'Custom field test1 adjusted to item')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_issue(self, p_send_email, p_ugt):
""" Test the update_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.get('/foo/issue/1/update')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/issue/1/update')
self.assertEqual(output.status_code, 302)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {
'status': 'Closed',
'close_status': 'fixed'
}
# Invalid repo
output = self.app.post('/bar/issue/1/update', data=data)
self.assertEqual(output.status_code, 404)
# Non-existing issue
output = self.app.post('/test/issue/100/update', data=data)
self.assertEqual(output.status_code, 404)
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertFalse(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# Right status, wrong csrf
data['close_status'] = 'Fixed'
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertFalse(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# working status update
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n '
'Issue close_status updated to: Fixed\n',
output.data)
self.assertIn(
'</button>\n '
'Issue status updated to: Closed (was: Open)\n',
output.data)
self.assertTrue(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# FIXME: There is likely something going wrong in the html
# below
self.assertIn(
'<small><p><strong>Metadata Update from '\
'<a href="https://pagure.org/user/pingou"> </a>'\
'''<a href="https://pagure.org/user/pingou"> @pingou</a></strong>:<br>
- Issue close_status updated to: Fixed<br>
- Issue status updated to: Closed (was: Open)</p></small>''',
output.data)
# Add new comment
data = {
'csrf_token': csrf_token,
'status': 'Closed',
'close_status': 'Fixed',
'comment': 'Woohoo a second comment !',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment added',
output.data)
self.assertNotIn(
'</button>\n No changes to edit',
output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
self.assertTrue(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# Add new tag
data = {
'csrf_token': csrf_token,
'status': 'Closed',
'close_status': 'Fixed',
'tag': 'tag2',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
self.assertTrue(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# Assign issue to an non-existent user
data = {
'csrf_token': csrf_token,
'status': 'Closed',
'close_status': 'Fixed',
'assignee': 'ralph',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n No user "ralph" found',
output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
self.assertTrue(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# Assign issue properly
data = {
'csrf_token': csrf_token,
'status': 'Closed',
'close_status': 'Fixed',
'assignee': 'pingou',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Issue assigned to pingou\n',
output.data)
self.assertTrue(
'<a href="/test/issues?assignee=pingou">' in output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
self.assertTrue(
'<option selected value="Fixed">Fixed</option>'
in output.data)
# Create another issue with a dependency
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Reset the status of the first issue
parent_issue = pagure.lib.search_issues(
self.session, repo, issueid=1)
parent_issue.status = 'Open'
self.session.add(parent_issue)
# Add the dependency relationship
self.session.add(parent_issue)
issue = pagure.lib.search_issues(self.session, repo, issueid=2)
issue.parents.append(parent_issue)
self.session.add(issue)
self.session.commit()
with tests.user_set(pagure.APP, user):
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/issue/2/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #2: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/2/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n You cannot close a ticket '
'that has ticket depending that are still open.',
output.data)
self.assertTrue(
'<option selected value="Open">Open</option>'
in output.data)
# Create private issue
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None,
private=True,
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Wrong user
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/test/issue/3/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 403)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1/update')
self.assertEqual(output.status_code, 302)
# Repo not set-up for issue tracker
output = self.app.post('/test/issue/1/update', data=data)
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_issue_drop_comment(self, p_send_email, p_ugt):
""" Test droping comment via the update_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Add new comment
data = {
'csrf_token': csrf_token,
'comment': 'Woohoo a second comment !',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment added',
output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 1)
data = {
'csrf_token': csrf_token,
'drop_comment': 1,
}
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
# Wrong issue id
output = self.app.post(
'/test/issue/3/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
# Wrong user
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 403)
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
# Drop the new comment
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment removed',
output.data)
# Drop non-existant comment
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 0)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_issue_depend(self, p_send_email, p_ugt):
""" Test adding dependency via the update_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue #2',
content='We should work on this again',
user='foo',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue #2')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Add a dependent ticket
data = {
'csrf_token': csrf_token,
'depends': '2',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
# Add an invalid dependent ticket
data = {
'csrf_token': csrf_token,
'depends': '2,abc',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertNotIn(
'</button>\n '
'Successfully edited issue #1',
output.data)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(issue.depends_text, [2])
self.assertEqual(issue.blocks_text, [])
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_issue_block(self, p_send_email, p_ugt):
""" Test adding blocked issue via the update_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue #2',
content='We should work on this again',
user='foo',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue #2')
# User is not an admin of the project
user = tests.FakeUser(username='foo')
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Add a dependent ticket
data = {
'csrf_token': csrf_token,
'blocks': '2',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(issue.depends_text, [])
self.assertEqual(issue.blocks_text, [])
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Add a dependent ticket
data = {
'csrf_token': csrf_token,
'blocks': '2',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
# Add an invalid dependent ticket
data = {
'csrf_token': csrf_token,
'blocks': '2,abc',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertNotIn(
'</button>\n '
'Successfully edited issue #1',
output.data)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(issue.depends_text, [])
self.assertEqual(issue.blocks_text, [2])
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_upload_issue(self, p_send_email, p_ugt):
""" Test the upload_issue endpoint. """
if not pyclamd:
raise SkipTest()
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
tests.create_projects_git(
os.path.join(self.path, 'tickets'), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
output = self.app.post('/foo/issue/1/upload')
self.assertEqual(output.status_code, 404)
output = self.app.post('/test/issue/100/upload')
self.assertEqual(output.status_code, 404)
# Invalid upload
data = {
'enctype': 'multipart/form-data',
}
output = self.app.post(
'/test/issue/1/upload', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
json_data = json.loads(output.data)
exp = {'output': 'notok'}
self.assertDictEqual(json_data, exp)
# TODO: Figure a way to enable this test on jenkins
# Try to attach a virus
if not os.environ.get('BUILD_ID'):
with tempfile.NamedTemporaryFile() as eicarfile:
eicarfile.write(pyclamd.ClamdUnixSocket().EICAR())
eicarfile.flush()
with open(eicarfile.name, 'rb') as stream:
data = {
'csrf_token': csrf_token,
'filestream': stream,
'enctype': 'multipart/form-data',
}
output = self.app.post(
'/test/issue/1/upload', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
json_data = json.loads(output.data)
exp = {
'output': 'notok',
}
self.assertDictEqual(json_data, exp)
# Attach a file to a ticket
with open(os.path.join(tests.HERE, 'placebo.png'), 'rb') as stream:
data = {
'csrf_token': csrf_token,
'filestream': stream,
'enctype': 'multipart/form-data',
}
output = self.app.post(
'/test/issue/1/upload', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
json_data = json.loads(output.data)
folder = os.path.dirname(
os.path.abspath(__file__))[1:].replace('/', '_')
exp = {
'output': 'ok',
'filelocation': '/test/issue/raw/files/8a06845923010b27bfd8'
'e7e75acff7badc40d1021b4994e01f5e11ca40bc3a'
'be-%s_placebo.png' % folder,
'filename': '%s_placebo.png' % folder,
}
self.assertDictEqual(json_data, exp)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
with tests.user_set(pagure.APP, user):
output = self.app.post('/test/issue/1/upload')
self.assertEqual(output.status_code, 404)
def test_view_issue_raw_file_empty(self):
""" Test the view_issue_raw_file endpoint. """
# Create the project and git repos
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path, 'tickets'), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
url = '/issue/raw/files/8a06845923010b27bfd8'\
'e7e75acff7badc40d1021b4994e01f5e11ca40bc3a'\
'be-home_pierrey_repos_gitrepo_pagure_tests'\
'_placebo.png'
output = self.app.get('/foo' + url)
self.assertEqual(output.status_code, 404)
output = self.app.get('/test' + url)
self.assertEqual(output.status_code, 404)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
output = self.app.get('/test' + url)
self.assertEqual(output.status_code, 404)
def test_view_issue_raw_file(self):
""" Test the view_issue_raw_file endpoint. """
# Create the issue and upload to it
self.test_upload_issue()
# Project w/ issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': True}
self.session.add(repo)
self.session.commit()
url = '/issue/raw/files/8a06845923010b27bfd8'\
'e7e75acff7badc40d1021b4994e01f5e11ca40bc3a'\
'be-%s_placebo.png' % os.path.dirname(
os.path.abspath(__file__))[1:].replace('/', '_')
output = self.app.get('/foo' + url)
self.assertEqual(output.status_code, 404)
output = self.app.get('/test/issue/raw/files/test.png')
self.assertEqual(output.status_code, 404)
# Access file by name
output = self.app.get('/test' + url)
self.assertEqual(output.status_code, 200)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
output = self.app.get('/test' + url)
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_edit_issue(self, p_send_email, p_ugt):
""" Test the edit_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.get('/foo/issue/1/edit')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/foo/issue/1/edit')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
output = self.app.get('/test/issue/1/edit')
self.assertEqual(output.status_code, 404)
# User not logged in
output = self.app.get('/foo/issue/1/edit')
self.assertEqual(output.status_code, 404)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1/edit')
self.assertEqual(output.status_code, 404)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1/edit')
self.assertEqual(output.status_code, 403)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1/edit')
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n Edit '
'issue #1\n </div>' in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {
'issue_content': 'We should work on this!'
}
output = self.app.post('/test/issue/1/edit', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n Edit '
'issue #1\n </div>' in output.data)
self.assertEqual(output.data.count(
'<small>\n This field is required. \n'
' </small>'), 1)
self.assertEqual(output.data.count(
'<small>\n Not a valid choice '
'\n </small>'), 1)
data['status'] = 'Open'
data['title'] = 'Test issue #1'
output = self.app.post('/test/issue/1/edit', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<div class="card-header">\n Edit '
'issue #1\n </div>' in output.data)
self.assertEqual(output.data.count(
'<small>\n This field is required. \n'
' </small>'), 0)
self.assertEqual(output.data.count(
'<small>\n Not a valid choice '
'\n </small>'), 0)
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/issue/1/edit', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<span class="issueid label label-default">#1</span>\n'
' <span id="issuetitle">Test issue #1</span>',
output.data)
self.assertEqual(output.data.count(
'<option selected value="Open">Open</option>'), 1)
self.assertEqual(output.data.count('comment_body">'), 1)
self.assertEqual(output.data.count(
'<p>We should work on this!</p>'), 1)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post('/test/issue/1/edit', data=data)
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_edit_tag(self, p_send_email, p_ugt):
""" Test the edit_tag endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.get('/foo/tag/foo/edit')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.get('/foo/tag/foo/edit')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(self.path)
output = self.app.get('/test/tag/foo/edit')
self.assertEqual(output.status_code, 403)
# User not logged in
output = self.app.get('/test/tag/foo/edit')
self.assertEqual(output.status_code, 302)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Add a tag to the issue
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
msg = pagure.lib.add_tag_obj(
session=self.session,
obj=issue,
tags='tag1',
user='pingou',
ticketfolder=None)
self.session.commit()
self.assertEqual(msg, 'Issue tagged with: tag1')
# Before edit, list tags
tags = pagure.lib.get_tags_of_project(self.session, repo)
self.assertEqual([tag.tag for tag in tags], ['tag1'])
# Edit tag
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
#Edit a tag that doesn't exit
output = self.app.get('/test/tag/does_not_exist/edit')
self.assertEqual(output.status_code, 404)
output = self.app.get('/test/tag/tag1/edit')
self.assertEqual(output.status_code, 200)
self.assertTrue('<strong>Edit tag: tag1</strong>' in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {'tag': 'tag2',
'tag_description': 'lorem ipsum',
'tag_color': 'DeepSkyBlue'}
output = self.app.post('/test/tag/tag1/edit', data=data)
self.assertEqual(output.status_code, 200)
self.assertTrue('<strong>Edit tag: tag1</strong>' in output.data)
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/tag/tag1/edit', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'Settings - test - Pagure', output.data)
self.assertIn(
'</button>\n '
'Edited tag: tag1()[DeepSkyBlue] to tag2(lorem ipsum)[DeepSkyBlue]',
output.data)
# update tag with empty description
data['tag_description'] = ''
output = self.app.post(
'/test/tag/tag2/edit', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'Settings - test - Pagure', output.data)
self.assertIn(
'</button>\n '
'Edited tag: tag2(lorem ipsum)[DeepSkyBlue] to tag2()[DeepSkyBlue]',
output.data)
# After edit, list tags
tags = pagure.lib.get_tags_of_project(self.session, repo)
self.assertEqual([tag.tag for tag in tags], ['tag2'])
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_remove_tag(self, p_send_email, p_ugt):
""" Test the remove_tag endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.post('/foo/droptag/')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.post('/foo/droptag/')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(self.path)
output = self.app.post('/test/droptag/')
self.assertEqual(output.status_code, 403)
# User not logged in
output = self.app.post('/test/droptag/')
self.assertEqual(output.status_code, 302)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Add a tag to the issue
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
msg = pagure.lib.add_tag_obj(
session=self.session,
obj=issue,
tags='tag1',
user='pingou',
ticketfolder=None)
self.session.commit()
self.assertEqual(msg, 'Issue tagged with: tag1')
# Before edit, list tags
tags = pagure.lib.get_tags_of_project(self.session, repo)
self.assertEqual([tag.tag for tag in tags], ['tag1'])
# Edit tag
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/test/droptag/', data={}, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertTrue(
'<title>Settings - test - Pagure</title>' in output.data)
self.assertTrue("<h3>Settings for test</h3>" in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {'tag': 'tag1'}
output = self.app.post(
'/test/droptag/', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertTrue("<h3>Settings for test</h3>" in output.data)
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/droptag/', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertTrue("<h3>Settings for test</h3>" in output.data)
self.assertIn(
'</button>\n '
'Issue **un**tagged with: tag1', output.data)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_delete_issue(self, p_send_email, p_ugt):
""" Test the delete_issue endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(self.path)
tests.create_projects_git(os.path.join(self.path, 'tickets'))
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/foo/issue/1/drop', follow_redirects=True)
self.assertEqual(output.status_code, 404)
output = self.app.post(
'/test/issue/100/drop', follow_redirects=True)
self.assertEqual(output.status_code, 404)
output = self.app.post(
'/test/issue/1/drop', follow_redirects=True)
self.assertEqual(output.status_code, 403)
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post(
'/test/issue/1/drop', follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data = {
}
# No CSRF token
output = self.app.post(
'/test/issue/1/drop', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
data['csrf_token'] = csrf_token
output = self.app.post(
'/test/issue/1/drop', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issues - test - Pagure</title>', output.data)
self.assertIn(
'</button>\n Issue deleted',
output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': False}
self.session.add(repo)
self.session.commit()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.post('/test/issue/1/drop', data=data)
self.assertEqual(output.status_code, 404)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_issue_edit_comment(self, p_send_email, p_ugt):
""" Test the issues edit comment endpoint """
p_send_email.return_value = True
p_ugt.return_value = True
tests.create_projects(self.session)
tests.create_projects_git(
os.path.join(self.path), bare=True)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1')
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Add new comment
data = {
'csrf_token': csrf_token,
'comment': 'Woohoo a second comment !',
}
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment added',
output.data)
self.assertTrue(
'<p>Woohoo a second comment !</p>' in output.data)
self.assertEqual(output.data.count('comment_body">'), 2)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 1)
self.assertEqual(
issue.comments[0].comment,
'Woohoo a second comment !')
data = {
'csrf_token': csrf_token,
'edit_comment': 1,
'update_comment': 'Updated comment',
}
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
# Wrong issue id
output = self.app.post(
'/test/issue/3/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 404)
# Wrong user
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 403)
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
# Edit comment
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment updated',
output.data)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 1)
self.assertEqual(issue.comments[0].comment, 'Updated comment')
with tests.user_set(pagure.APP, user):
output = self.app.get('/test/issue/1/comment/1/edit')
self.assertIn(
'<title>test - Pagure</title>', output.data)
self.assertTrue('<div id="edit">' in output.data)
self.assertTrue('<section class="edit_comment">' in output.data)
self.assertTrue(
'<textarea class="form-control" id="update_comment"'
in output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
data['csrf_token'] = csrf_token
data['update_comment'] = 'Second update'
# Edit the comment with the other endpoint
output = self.app.post(
'/test/issue/1/comment/1/edit',
data=data,
follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Issue #1: Test issue - test - Pagure</title>',
output.data)
self.assertIn(
'<a class="btn btn-primary btn-sm" '
'href="/test/issue/1/edit" title="Edit this issue">',
output.data)
self.assertIn(
'</button>\n Comment updated',
output.data)
repo = pagure.lib.get_project(self.session, 'test')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 1)
self.assertEqual(issue.comments[0].comment, 'Second update')
# Create another issue from someone else
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='foo',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 1)
self.assertEqual(issue.status, 'Open')
issue = pagure.lib.search_issues(self.session, repo, issueid=2)
self.assertEqual(len(issue.comments), 0)
self.assertEqual(issue.status, 'Open')
user = tests.FakeUser(username='foo')
with tests.user_set(pagure.APP, user):
data = {
'csrf_token': csrf_token,
'comment': 'Nevermind figured it out',
'status': 'Closed',
'close_status': 'Invalid'
}
# Add a comment and close the ticket #1
output = self.app.post(
'/test/issue/1/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertNotIn(
'</button>\n '
'Successfully edited issue #1\n',
output.data
)
self.assertIn(
'</button>\n Comment added\n',
output.data
)
self.assertNotIn(
'editmetadatatoggle">\n Edit Metadata',
output.data
)
data = {
'csrf_token': csrf_token,
'comment': 'Nevermind figured it out',
'status': 'Closed',
'close_status': 'Invalid'
}
# Add a comment and close the ticket #2
output = self.app.post(
'/test/issue/2/update', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'</button>\n '
'Issue close_status updated to: Invalid\n',
output.data
)
self.assertIn(
'</button>\n Comment added\n',
output.data
)
self.assertIn(
'</button>\n '
'Issue status updated to: Closed (was: Open)\n',
output.data
)
self.assertIn(
'editmetadatatoggle">\n Edit Metadata',
output.data
)
# Ticket #1 has one more comment and is still open
issue = pagure.lib.search_issues(self.session, repo, issueid=1)
self.assertEqual(len(issue.comments), 2)
self.assertEqual(issue.status, 'Open')
# Ticket #2 has one less comment and is closed
issue = pagure.lib.search_issues(self.session, repo, issueid=2)
self.assertEqual(len(issue.comments), 2)
self.assertEqual(
issue.comments[0].comment,
'Nevermind figured it out')
self.assertEqual(
issue.comments[1].comment,
'**Metadata Update from @foo**:\n'
'- Issue close_status updated to: Invalid\n'
'- Issue status updated to: Closed (was: Open)')
self.assertEqual(issue.status, 'Closed')
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_git_urls(self, p_send_email, p_ugt):
""" Check that the url to the git repo for issues is present/absent when
it should.
"""
p_send_email.return_value = True
p_ugt.return_value = True
self.test_view_issues()
user = tests.FakeUser()
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
# Check that the git issue URL is present
output = self.app.get('/test')
self.assertNotIn(
'<h5><strong>Issues GIT URLs</strong></h5>', output.data)
# Project w/o issue tracker
repo = pagure.lib.get_project(self.session, 'test')
repo.settings = {'issue_tracker': True}
self.session.add(repo)
self.session.commit()
# Check that the git issue URL is gone
output = self.app.get('/test')
self.assertIn(
'<h5><strong>Issues GIT URLs</strong></h5>', output.data)
@patch('pagure.lib.git.update_git')
@patch('pagure.lib.notify.send_email')
def test_update_tags(self, p_send_email, p_ugt):
""" Test the update_tags endpoint. """
p_send_email.return_value = True
p_ugt.return_value = True
# No Git repo
output = self.app.post('/foo/update/tags')
self.assertEqual(output.status_code, 404)
user = tests.FakeUser()
with tests.user_set(pagure.APP, user):
output = self.app.post('/foo/update/tags')
self.assertEqual(output.status_code, 404)
tests.create_projects(self.session)
tests.create_projects_git(self.path)
output = self.app.post('/test/update/tags')
self.assertEqual(output.status_code, 403)
# User not logged in
output = self.app.post('/test/update/tags')
self.assertEqual(output.status_code, 302)
# Create issues to play with
repo = pagure.lib.get_project(self.session, 'test')
msg = pagure.lib.new_issue(
session=self.session,
repo=repo,
title='Test issue',
content='We should work on this',
user='pingou',
ticketfolder=None
)
self.session.commit()
self.assertEqual(msg.title, 'Test issue')
# Before update, list tags
tags = pagure.lib.get_tags_of_project(self.session, repo)
self.assertEqual([tag.tag for tag in tags], [])
user.username = 'pingou'
with tests.user_set(pagure.APP, user):
# No CSRF
data = {
'tag': 'red',
'tag_description': 'lorem ipsum',
'tag_color': '#ff0000'
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
' <ul class="list-group list-group-flush">'
'\n </ul>', output.data)
csrf_token = output.data.split(
'name="csrf_token" type="hidden" value="')[1].split('">')[0]
# Invalid color
data = {
'tag': 'red',
'tag_description': 'lorem ipsum',
'tag_color': 'red',
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'</button>\n '
'Color: red does not match the expected pattern',
output.data)
self.assertIn(
' <ul class="list-group list-group-flush">'
'\n </ul>', output.data)
# Inconsistent length tags (missing tag field)
data = {
'tag': 'red',
'tag_description': ['lorem ipsum', 'foo bar'],
'tag_color': ['#ff0000', '#003cff'],
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'</button>\n Error: Incomplete request. '
'One or more tag fields missing.', output.data)
self.assertIn(
' <ul class="list-group list-group-flush">'
'\n </ul>', output.data)
# Inconsistent length color
data = {
'tag': ['red', 'blue'],
'tag_description': ['lorem ipsum', 'foo bar'],
'tag_color': 'red',
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'</button>\n '
'Color: red does not match the expected pattern',
output.data)
self.assertIn(
'</button>\n Error: Incomplete request. '
'One or more tag color fields missing.', output.data)
self.assertIn(
' <ul class="list-group list-group-flush">'
'\n </ul>', output.data)
# Inconsistent length description
data = {
'tag': ['red', 'blue'],
'tag_description': 'lorem ipsum',
'tag_color': ['#ff0000', '#003cff'],
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'</button>\n Error: Incomplete request. '
'One or more tag description fields missing.', output.data)
self.assertIn(
' <ul class="list-group list-group-flush">'
'\n </ul>', output.data)
# consistent length, but empty description
data = {
'tag': ['red', 'blue'],
'tag_description': ['lorem ipsum', ''],
'tag_color': ['#ff0000', '#003cff'],
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'<span class="label label-info" style="background-color:'
'#003cff">blue</span>\n'
' <span class="text-muted">'
'</span>', output.data)
self.assertIn(
'<input type="hidden" value="blue" name="tag" />',
output.data)
self.assertIn(
'<span class="label label-info" style="background-color:'
'#ff0000">red</span>\n'
' <span class="text-muted">lorem ipsum'
'</span>', output.data)
self.assertIn(
'<input type="hidden" value="red" name="tag" />',
output.data)
# Valid query
data = {
'tag': ['red', 'green'],
'tag_description': ['lorem ipsum', 'sample description'],
'tag_color': ['#ff0000', '#00ff00'],
'csrf_token': csrf_token,
}
output = self.app.post(
'/test/update/tags', data=data, follow_redirects=True)
self.assertEqual(output.status_code, 200)
self.assertIn(
'<title>Settings - test - Pagure</title>', output.data)
self.assertIn(
'<span class="label label-info" style="background-color:'
'#00ff00">green</span>\n'
' <span class="text-muted">sample description'
'</span>', output.data)
self.assertIn(
'<input type="hidden" value="green" name="tag" />',
output.data)
self.assertIn(
'<span class="label label-info" style="background-color:'
'#ff0000">red</span>\n'
' <span class="text-muted">lorem ipsum'
'</span>', output.data)
self.assertIn(
'<input type="hidden" value="red" name="tag" />',
output.data)
# After update, list tags
tags = pagure.lib.get_tags_of_project(self.session, repo)
self.assertEqual([tag.tag for tag in tags], ['blue', 'green', 'red'])
if __name__ == '__main__':
SUITE = unittest.TestLoader().loadTestsFromTestCase(PagureFlaskIssuestests)
unittest.TextTestRunner(verbosity=2).run(SUITE)